Move no_mentions handler to being a sub-handler of check_commits

Author: Urgau

src/handlers.rs

@@ -37,7 +37,6 @@ mod major_change;
 mod mentions;
 mod merge_conflicts;
 mod milestone_prs;
-mod no_mentions;
 mod no_merges;
 mod nominate;
 mod note;
@@ -234,7 +233,6 @@ issue_handlers! {
     review_requested,
     pr_tracking,
     validate_config,
-    no_mentions,
 }
 
 macro_rules! command_handlers {

src/handlers/check_commits.rs

@@ -8,6 +8,7 @@ use crate::{
 };
 
 mod modified_submodule;
+mod no_mentions;
 mod non_default_branch;
 
 /// Key for the state in the database
@@ -41,6 +42,7 @@ pub(super) async fn handle(ctx: &Context, event: &Event, config: &Config) -> any
             event.issue.number
         )
     };
+    let commits = event.issue.commits(&ctx.github).await?;
 
     let mut warnings = Vec::new();
 
@@ -58,6 +60,10 @@ pub(super) async fn handle(ctx: &Context, event: &Event, config: &Config) -> any
         warnings.extend(modified_submodule::modifies_submodule(diff));
     }
 
+    if let Some(no_mentions) = &config.no_mentions {
+        warnings.extend(no_mentions::mentions_in_commits(no_mentions, &commits));
+    }
+
     handle_warnings(ctx, event, warnings).await
 }
 

src/handlers/check_commits/no_mentions.rs

@@ -0,0 +1,56 @@
+//! Purpose: When opening a PR, or pushing new changes, check for github mentions
+//! in commits and notify the user of our no-mentions in commits policy.
+
+use std::fmt::Write;
+
+use crate::{config::NoMentionsConfig, github::GithubCommit};
+
+pub(super) fn mentions_in_commits(
+    _conf: &NoMentionsConfig,
+    commits: &[GithubCommit],
+) -> Option<String> {
+    let mut mentions_commits = Vec::new();
+
+    for commit in commits {
+        if !parser::get_mentions(&commit.commit.message).is_empty() {
+            mentions_commits.push(&*commit.sha);
+        }
+    }
+
+    if mentions_commits.is_empty() {
+        None
+    } else {
+        Some(mentions_in_commits_warn(mentions_commits))
+    }
+}
+
+fn mentions_in_commits_warn(commits: Vec<&str>) -> String {
+    let mut warning =
+        format!("There are mentions (`@user`) in the following commits, please remove them.\n");
+
+    for commit in commits {
+        let _ = writeln!(warning, "    - {commit}");
+    }
+
+    warning
+}
+
+#[test]
+fn test_warning_printing() {
+    let commits_to_warn = vec![
+        "4d6ze57403udfrzefrfe6574",
+        "f54efz57405u46z6ef465z4f6ze57",
+        "404u57403uzf5fe5f4f5e57405u4zf",
+    ];
+
+    let msg = mentions_in_commits_warn(commits_to_warn);
+
+    assert_eq!(
+        msg,
+        r#"There are mentions (`@user`) in the following commits, please remove them.
+    - 4d6ze57403udfrzefrfe6574
+    - f54efz57405u46z6ef465z4f6ze57
+    - 404u57403uzf5fe5f4f5e57405u4zf
+"#
+    );
+}