[TRY] Completely refactor std_detect tests

+ Add `avx512pf` and `avx512er` to `cpuid.def`

Author: sayantn

.github/workflows/main.yml

@@ -151,7 +151,6 @@ jobs:
             tuple: x86_64-unknown-linux-gnu-emulated
             os: ubuntu-latest
           test_everything: true
-          rustflags: --cfg stdarch_intel_sde
         # MIPS targets disabled since they are dropped to tier 3.
         # See https://github.com/rust-lang/compiler-team/issues/648
         #- target:
@@ -216,12 +215,9 @@ jobs:
     - run: echo "NORUN=1" >> $GITHUB_ENV
       shell: bash
       if: matrix.norun != '' || startsWith(matrix.target.tuple, 'thumb') || matrix.target.tuple == 'nvptx64-nvidia-cuda'
-    - run: echo "STDARCH_TEST_EVERYTHING=1" >> $GITHUB_ENV
+    - run: echo "RUSTFLAGS=--cfg stdarch_test_everything" >> $GITHUB_ENV
       shell: bash
       if: matrix.test_everything != ''
-    - run: echo "RUSTFLAGS=${{ matrix.rustflags }}" >> $GITHUB_ENV
-      shell: bash
-      if: matrix.rustflags != ''
     - run: echo "STDARCH_DISABLE_ASSERT_INSTR=1" >> $GITHUB_ENV
       shell: bash
       if: matrix.disable_assert_instr != ''

ci/docker/x86_64-unknown-linux-gnu-emulated/cpuid.def

@@ -29,7 +29,7 @@
 00000004 00000004 => 00000000 00000000 00000000 00000000
 00000005 ******** => 00000040 00000040 00000003 00042120 #MONITOR/MWAIT
 00000006 ******** => 00000077 00000002 00000001 00000000 #Thermal and Power
-00000007 00000000 => 00000001 f3bfbfbf bbc05ffe 03d55130 #Extended Features
+00000007 00000000 => 00000001 ffbfbfbf bbc05ffe 03d55130 #Extended Features
 00000007 00000001 => 88ee00bf 00000002 00000000 1d29cd3e
 00000008 ******** => 00000000 00000000 00000000 00000000
 00000009 ******** => 00000000 00000000 00000000 00000000 #Direct Cache

ci/run-docker.sh

@@ -23,13 +23,10 @@ run() {
       --env CARGO_HOME=/cargo \
       --env CARGO_TARGET_DIR=/checkout/target \
       --env TARGET="${target}" \
-      --env STDARCH_TEST_EVERYTHING \
-      --env STDARCH_ASSERT_INSTR_IGNORE \
       --env STDARCH_DISABLE_ASSERT_INSTR \
       --env NOSTD \
       --env NORUN \
       --env RUSTFLAGS \
-      --env STDARCH_TEST_NORUN \
       --volume "${HOME}/.cargo":/cargo \
       --volume "$(rustc --print sysroot)":/rust:ro \
       --volume "$(pwd)":/checkout:ro \

ci/run.sh

@@ -62,7 +62,6 @@ echo "RUSTFLAGS=${RUSTFLAGS}"
 echo "FEATURES=${FEATURES}"
 echo "OBJDUMP=${OBJDUMP}"
 echo "STDARCH_DISABLE_ASSERT_INSTR=${STDARCH_DISABLE_ASSERT_INSTR}"
-echo "STDARCH_TEST_EVERYTHING=${STDARCH_TEST_EVERYTHING}"
 echo "PROFILE=${PROFILE}"
 
 cargo_test() {

crates/core_arch/Cargo.toml

@@ -28,7 +28,7 @@ std_detect = { version = "0.*", path = "../std_detect" }
 syscalls = { version = "0.6.18", default-features = false }
 
 [lints.rust]
-unexpected_cfgs = {level = "warn", check-cfg = ['cfg(stdarch_intel_sde)'] }
+unexpected_cfgs = {level = "warn", check-cfg = ['cfg(stdarch_test_everything)'] }
 
 [lints.clippy]
 too_long_first_doc_paragraph = "allow"

crates/core_arch/src/x86/xsave.rs

@@ -185,7 +185,7 @@ mod tests {
         }
     }
 
-    #[cfg_attr(stdarch_intel_sde, ignore)]
+    #[cfg_attr(stdarch_test_everything, ignore)]
     #[simd_test(enable = "xsave")]
     #[cfg_attr(miri, ignore)] // Register saving/restoring is not supported in Miri
     unsafe fn test_xsave() {
@@ -208,7 +208,7 @@ mod tests {
         assert_eq!(xcr, xcr_cpy);
     }
 
-    #[cfg_attr(stdarch_intel_sde, ignore)]
+    #[cfg_attr(stdarch_test_everything, ignore)]
     #[simd_test(enable = "xsave,xsaveopt")]
     #[cfg_attr(miri, ignore)] // Register saving/restoring is not supported in Miri
     unsafe fn test_xsaveopt() {

crates/core_arch/src/x86_64/xsave.rs

@@ -149,7 +149,7 @@ mod tests {
         }
     }
 
-    #[cfg_attr(stdarch_intel_sde, ignore)]
+    #[cfg_attr(stdarch_test_everything, ignore)]
     #[simd_test(enable = "xsave")]
     #[cfg_attr(miri, ignore)] // Register saving/restoring is not supported in Miri
     unsafe fn test_xsave64() {
@@ -162,7 +162,7 @@ mod tests {
         xsave::_xsave64(b.ptr(), m);
     }
 
-    #[cfg_attr(stdarch_intel_sde, ignore)]
+    #[cfg_attr(stdarch_test_everything, ignore)]
     #[simd_test(enable = "xsave,xsaveopt")]
     #[cfg_attr(miri, ignore)] // Register saving/restoring is not supported in Miri
     unsafe fn test_xsaveopt64() {

crates/std_detect/Cargo.toml

@@ -40,3 +40,6 @@ rustc-dep-of-std = [
     "compiler_builtins",
     "alloc",
 ]
+
+[lints.rust]
+unexpected_cfgs = {level = "warn", check-cfg = ['cfg(stdarch_test_everything)'] }

crates/std_detect/src/detect/macros.rs

@@ -140,6 +140,17 @@ macro_rules! features {
             )*
         }
 
+        #[test]
+        #[cfg($cfg)]
+        #[cfg(stdarch_test_everything)]
+        fn everything_present() {
+            $(
+                assert!($crate::detect::check_for($crate::detect::Feature::$feature),
+                    concat!("Feature ", $feature_lit, " is not present on this target")
+                );
+            )*
+        }
+
         /// Each variant denotes a position in a bitset for a particular feature.
         ///
         /// PLEASE: do not use this, it is an implementation detail subject