Rename has_missing_errors to has_unformatted_original_code

Author: davidBar-On

src/formatting.rs

@@ -333,7 +333,7 @@ pub(crate) struct ReportedErrors {
     pub(crate) has_diff: bool,
 
     /// Formatted code missed something, like lost comments or extra trailing space
-    pub(crate) has_missing_errors: bool,
+    pub(crate) has_unformatted_original_code: bool,
 }
 
 impl ReportedErrors {
@@ -345,7 +345,7 @@ impl ReportedErrors {
         self.has_macro_format_failure |= other.has_macro_format_failure;
         self.has_check_errors |= other.has_check_errors;
         self.has_diff |= other.has_diff;
-        self.has_missing_errors |= other.has_missing_errors;
+        self.has_unformatted_original_code |= other.has_unformatted_original_code;
     }
 }
 

src/lib.rs

@@ -210,7 +210,10 @@ impl FormatReport {
         if !new_errors.is_empty() {
             errs.has_formatting_errors = true;
         }
-        if errs.has_operational_errors && errs.has_check_errors && errs.has_missing_errors {
+        if errs.has_operational_errors
+            && errs.has_check_errors
+            && errs.has_unformatted_original_code
+        {
             return;
         }
         for err in new_errors {
@@ -220,10 +223,10 @@ impl FormatReport {
                 }
                 ErrorKind::TrailingWhitespace => {
                     errs.has_operational_errors = true;
-                    errs.has_missing_errors = true;
+                    errs.has_unformatted_original_code = true;
                 }
                 ErrorKind::LostComment => {
-                    errs.has_missing_errors = true;
+                    errs.has_unformatted_original_code = true;
                 }
                 ErrorKind::BadIssue(_)
                 | ErrorKind::LicenseCheck
@@ -313,7 +316,7 @@ fn format_snippet(snippet: &str, config: &Config, is_macro_def: bool) -> Option<
                 session.errors.has_macro_format_failure
                     || session.out.as_ref().unwrap().is_empty() && !snippet.is_empty()
                     || result.is_err()
-                    || (is_macro_def && session.has_missing_errors()),
+                    || (is_macro_def && session.has_unformatted_original_code()),
                 result,
             )
         };
@@ -488,8 +491,8 @@ impl<'b, T: Write + 'b> Session<'b, T> {
         self.errors.has_diff
     }
 
-    pub fn has_missing_errors(&self) -> bool {
-        self.errors.has_missing_errors
+    pub fn has_unformatted_original_code(&self) -> bool {
+        self.errors.has_unformatted_original_code
     }
 
     pub fn has_no_errors(&self) -> bool {
@@ -498,7 +501,7 @@ impl<'b, T: Write + 'b> Session<'b, T> {
             || self.has_formatting_errors()
             || self.has_check_errors()
             || self.has_diff()
-            || self.has_missing_errors()
+            || self.has_unformatted_original_code()
             || self.errors.has_macro_format_failure)
     }
 }