Skip to content

Better note limitations and purpose of the hash #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Noratrieb opened this issue Feb 19, 2025 · 1 comment
Open

Better note limitations and purpose of the hash #58

Noratrieb opened this issue Feb 19, 2025 · 1 comment

Comments

@Noratrieb
Copy link
Member

It came up in #56 (comment) that someone had problems because the hash broke over a minor release. I think that's fine for the intended purpose of the hash (hashmaps), but this should be better explained in the readme.

@sstadick
Copy link

sstadick commented Mar 4, 2025

@Noratrieb - The Rust Performance book specifically points to using this: https://nnethercote.github.io/perf-book/hashing.html

Additionally, there are nearly 1000 other crates that depend on this: https://lib.rs/crates/rustc-hash

This change also broke my project. Given this crate is under the rust-lang org, I don't think it's too onerous to ask that it follows semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants