From 85d70286eb2ad3a134c65d91320da689fb3483f6 Mon Sep 17 00:00:00 2001 From: Takayuki Nakata Date: Tue, 4 Aug 2020 22:20:38 +0900 Subject: [PATCH 1/4] Enable a link --- src/queries/incremental-compilation-in-detail.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/queries/incremental-compilation-in-detail.md b/src/queries/incremental-compilation-in-detail.md index d8716acdf..a4e1cd92b 100644 --- a/src/queries/incremental-compilation-in-detail.md +++ b/src/queries/incremental-compilation-in-detail.md @@ -507,9 +507,10 @@ session. The overhead of doing so is a few percent of total compilation time. Data structures used as query results could be factored in a way that removes edges from the dependency graph. Especially "span" information is very volatile, so including it in query result will increase the chance that that result won't -be reusable. See https://github.com/rust-lang/rust/issues/47389 for more +be reusable. See [https://github.com/rust-lang/rust/issues/47389] for more information. [query-model]: ./query-evaluation-model-in-detail.html +[https://github.com/rust-lang/rust/issues/47389]: https://github.com/rust-lang/rust/issues/47389 From 38357f9a60088743386107fd0f4fefdc1241be91 Mon Sep 17 00:00:00 2001 From: Takayuki Nakata Date: Tue, 4 Aug 2020 22:21:19 +0900 Subject: [PATCH 2/4] Fix a broken link --- src/parallel-rustc.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parallel-rustc.md b/src/parallel-rustc.md index add902d3a..0405a947a 100644 --- a/src/parallel-rustc.md +++ b/src/parallel-rustc.md @@ -18,7 +18,7 @@ There are a few basic ideas in this effort: thread-safe. A key strategy here has been converting interior-mutable data-structures (e.g. `Cell`) into their thread-safe siblings (e.g. `Mutex`). -[`rayon`]: https://crates.io/rayon +[`rayon`]: https://crates.io/crates/rayon As of this writing, much of this effort is on hold due to lack of manpower. We have a working prototype with promising performance gains in many cases. From 37ed587bfedcf61bbacf3364df8dbe39d59bee7b Mon Sep 17 00:00:00 2001 From: Takayuki Nakata Date: Tue, 4 Aug 2020 22:26:06 +0900 Subject: [PATCH 3/4] Fix typo --- src/name-resolution.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/name-resolution.md b/src/name-resolution.md index dfea5f22c..cc6eed7f8 100644 --- a/src/name-resolution.md +++ b/src/name-resolution.md @@ -13,7 +13,7 @@ resolve a name once, since no new names can be added. If we fail to resolve a name now, then it is a compiler error. Name resolution can be complex. There are a few different namespaces (e.g. -macros, values, types, lifetimes), and names my be valid at different (nested) +macros, values, types, lifetimes), and names may be valid at different (nested) scopes. Also, different types of names can fail to be resolved differently, and failures can happen differently at different scopes. For example, for a module scope, failure means no unexpanded macros and no unresolved glob imports in From b9d160bd3b896aae141616d5a75c0413776e14fc Mon Sep 17 00:00:00 2001 From: Takayuki Nakata Date: Tue, 4 Aug 2020 22:40:10 +0900 Subject: [PATCH 4/4] Use angle brackets to turn URL into a link --- src/queries/incremental-compilation-in-detail.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/queries/incremental-compilation-in-detail.md b/src/queries/incremental-compilation-in-detail.md index a4e1cd92b..96255227f 100644 --- a/src/queries/incremental-compilation-in-detail.md +++ b/src/queries/incremental-compilation-in-detail.md @@ -507,10 +507,9 @@ session. The overhead of doing so is a few percent of total compilation time. Data structures used as query results could be factored in a way that removes edges from the dependency graph. Especially "span" information is very volatile, so including it in query result will increase the chance that that result won't -be reusable. See [https://github.com/rust-lang/rust/issues/47389] for more +be reusable. See for more information. [query-model]: ./query-evaluation-model-in-detail.html -[https://github.com/rust-lang/rust/issues/47389]: https://github.com/rust-lang/rust/issues/47389