@@ -323,7 +323,7 @@ feel comfortable jumping straight into the large `rust-lang/rust` codebase.
323
323
The following tasks are doable without much background knowledge but are
324
324
incredibly helpful:
325
325
326
- - [ ICE-breakers Cleanup crew] [ iceb ] : find minimal reproductions of ICEs, bisect
326
+ - [ Cleanup crew] [ iceb ] : find minimal reproductions of ICEs, bisect
327
327
regressions, etc. This is a way of helping that saves a ton of time for
328
328
others to fix an error later.
329
329
- Writing documentation: if you are feeling a bit more intrepid, you could try
@@ -357,7 +357,7 @@ below][break]) for some PRs.
357
357
[ break ] : #breaking-changes
358
358
359
359
When the PR is ready to be merged, the reviewer will issue a command to
360
- ` @bors ` , the CI bot. Usually, this is ` @bors r+ ` or ` @bors r=@ user ` to approve
360
+ ` @bors ` , the CI bot. Usually, this is ` @bors r+ ` or ` @bors r=user ` to approve
361
361
a PR (there are few other commands, but they are less relevant here). This puts
362
362
the PR in [ bors's queue] [ bors ] to be tested and merged. Be patient; this can take a
363
363
while and the queue can sometimes be long. PRs are never merged by hand.
@@ -410,7 +410,7 @@ approval of the relevant teams.
410
410
411
411
After that, the feature gate can be removed and the feature turned on for all users.
412
412
413
- [ For more details on this process, see this chapter.] ( ./implementing_new_features.md )
413
+ [ For more details on this process, see this chapter on implementing new features .] ( ./implementing_new_features.md )
414
414
415
415
### Breaking Changes
416
416
@@ -428,7 +428,7 @@ discuss the issue and either accept, reject, or request changes on the PR.
428
428
429
429
If the scale of breakage is large, a deprecation warning may be needed. This is
430
430
a warning that the compiler will display to users whose code will break in the
431
- future. After some time, an FCP can be used to move forward with the actual
431
+ future. After some time, an FCP can be used to move forward with the actual
432
432
breakage.
433
433
434
434
If the scale of breakage is unknown, a team member or contributor may request a
@@ -449,7 +449,7 @@ compiler (as opposed to a full RFC or a design meeting with the team).
449
449
Example of things that might require MCPs include major refactorings, changes
450
450
to important types, or important changes to how the compiler does something.
451
451
452
- ** When in doubt, ask on [ zulip] [ z ] . We would hate for you to put a lot of work
452
+ ** When in doubt, ask on [ zulip] [ z ] . It would be a shame to put a lot of work
453
453
into a PR that ends up not getting merged!**
454
454
455
455
### Performance
0 commit comments