diff --git a/src/libstd/io/comm_adapters.rs b/src/libstd/io/comm_adapters.rs
index 7a78800c33d35..7a79857e7547e 100644
--- a/src/libstd/io/comm_adapters.rs
+++ b/src/libstd/io/comm_adapters.rs
@@ -117,7 +117,6 @@ mod test {
use prelude::*;
use super::*;
use io;
- use comm;
use task;
#[test]
@@ -136,7 +135,7 @@ mod test {
assert_eq!(false, reader.eof());
- assert_eq!(Some(0), reader.read(~[]));
+ assert_eq!(Some(0), reader.read([]));
assert_eq!(false, reader.eof());
assert_eq!(Some(3), reader.read(buf));
diff --git a/src/libstd/option.rs b/src/libstd/option.rs
index 0e55ad732d714..5467a894cff3b 100644
--- a/src/libstd/option.rs
+++ b/src/libstd/option.rs
@@ -43,7 +43,7 @@ use clone::DeepClone;
use cmp::{Eq, TotalEq, TotalOrd};
use default::Default;
use fmt;
-use iter::{Iterator, DoubleEndedIterator, ExactSize};
+use iter::{Iterator, DoubleEndedIterator, FromIterator, ExactSize};
use kinds::Send;
use str::OwnedStr;
use to_str::ToStr;
@@ -410,6 +410,46 @@ impl DoubleEndedIterator for OptionIterator {
impl ExactSize for OptionIterator {}
+/////////////////////////////////////////////////////////////////////////////
+// Free functions
+/////////////////////////////////////////////////////////////////////////////
+
+/// Takes each element in the `Iterator`: if it is `None`, no further
+/// elements are taken, and the `None` is returned. Should no `None` occur, a
+/// vector containing the values of each `Option` is returned.
+///
+/// Here is an example which increments every integer in a vector,
+/// checking for overflow:
+///
+/// fn inc_conditionally(x: uint) -> Option {
+/// if x == uint::max_value { return None; }
+/// else { return Some(x+1u); }
+/// }
+/// let v = [1u, 2, 3];
+/// let res = collect(v.iter().map(|&x| inc_conditionally(x)));
+/// assert!(res == Some(~[2u, 3, 4]));
+#[inline]
+pub fn collect>, V: FromIterator>(iter: Iter) -> Option {
+ // FIXME(#11084): This should be twice as fast once this bug is closed.
+ let mut iter = iter.scan(false, |state, x| {
+ match x {
+ Some(x) => Some(x),
+ None => {
+ *state = true;
+ None
+ }
+ }
+ });
+
+ let v: V = FromIterator::from_iterator(&mut iter);
+
+ if iter.state {
+ None
+ } else {
+ Some(v)
+ }
+}
+
/////////////////////////////////////////////////////////////////////////////
// Tests
/////////////////////////////////////////////////////////////////////////////
@@ -418,8 +458,10 @@ impl ExactSize for OptionIterator {}
mod tests {
use super::*;
+ use iter::range;
use str::StrSlice;
use util;
+ use vec::ImmutableVector;
#[test]
fn test_get_ptr() {
@@ -661,4 +703,26 @@ mod tests {
assert!(!x.mutate_default(0i, |i| i+1));
assert_eq!(x, Some(0i));
}
+
+ #[test]
+ fn test_collect() {
+ let v: Option<~[int]> = collect(range(0, 0)
+ .map(|_| Some(0)));
+ assert_eq!(v, Some(~[]));
+
+ let v: Option<~[int]> = collect(range(0, 3)
+ .map(|x| Some(x)));
+ assert_eq!(v, Some(~[0, 1, 2]));
+
+ let v: Option<~[int]> = collect(range(0, 3)
+ .map(|x| if x > 1 { None } else { Some(x) }));
+ assert_eq!(v, None);
+
+ // test that it does not take more elements than it needs
+ let functions = [|| Some(()), || None, || fail!()];
+
+ let v: Option<~[()]> = collect(functions.iter().map(|f| (*f)()));
+
+ assert_eq!(v, None);
+ }
}
diff --git a/src/libstd/result.rs b/src/libstd/result.rs
index 79198d0314f87..2dbba3096982f 100644
--- a/src/libstd/result.rs
+++ b/src/libstd/result.rs
@@ -13,12 +13,10 @@
use clone::Clone;
use cmp::Eq;
use fmt;
-use iter::Iterator;
+use iter::{Iterator, FromIterator};
use option::{None, Option, Some};
use str::OwnedStr;
use to_str::ToStr;
-use vec::OwnedVector;
-use vec;
/// `Result` is a type that represents either success (`Ok`) or failure (`Err`).
#[deriving(Clone, DeepClone, Eq, Ord, TotalEq, TotalOrd, ToStr)]
@@ -221,10 +219,9 @@ impl fmt::Default for Result {
// Free functions
/////////////////////////////////////////////////////////////////////////////
-/// Takes each element in the iterator: if it is an error, no further
-/// elements are taken, and the error is returned.
-/// Should no error occur, a vector containing the values of each Result
-/// is returned.
+/// Takes each element in the `Iterator`: if it is an `Err`, no further
+/// elements are taken, and the `Err` is returned. Should no `Err` occur, a
+/// vector containing the values of each `Result` is returned.
///
/// Here is an example which increments every integer in a vector,
/// checking for overflow:
@@ -237,17 +234,24 @@ impl fmt::Default for Result {
/// let res = collect(v.iter().map(|&x| inc_conditionally(x)));
/// assert!(res == Ok(~[2u, 3, 4]));
#[inline]
-pub fn collect>>(mut iterator: Iter)
- -> Result<~[T], E> {
- let (lower, _) = iterator.size_hint();
- let mut vs: ~[T] = vec::with_capacity(lower);
- for t in iterator {
- match t {
- Ok(v) => vs.push(v),
- Err(u) => return Err(u)
+pub fn collect>, V: FromIterator>(iter: Iter) -> Result {
+ // FIXME(#11084): This should be twice as fast once this bug is closed.
+ let mut iter = iter.scan(None, |state, x| {
+ match x {
+ Ok(x) => Some(x),
+ Err(err) => {
+ *state = Some(err);
+ None
+ }
}
+ });
+
+ let v: V = FromIterator::from_iterator(&mut iter);
+
+ match iter.state {
+ Some(err) => Err(err),
+ None => Ok(v),
}
- Ok(vs)
}
/// Perform a fold operation over the result values from an iterator.
@@ -291,8 +295,8 @@ mod tests {
use super::*;
use iter::range;
- use vec::ImmutableVector;
use to_str::ToStr;
+ use vec::ImmutableVector;
pub fn op1() -> Result { Ok(666) }
pub fn op2() -> Result { Err(~"sadface") }
@@ -347,21 +351,21 @@ mod tests {
#[test]
fn test_collect() {
- assert_eq!(collect(range(0, 0)
- .map(|_| Ok::(0))),
- Ok(~[]));
- assert_eq!(collect(range(0, 3)
- .map(|x| Ok::(x))),
- Ok(~[0, 1, 2]));
- assert_eq!(collect(range(0, 3)
- .map(|x| if x > 1 { Err(x) } else { Ok(x) })),
- Err(2));
+ let v: Result<~[int], ()> = collect(range(0, 0).map(|_| Ok::(0)));
+ assert_eq!(v, Ok(~[]));
+
+ let v: Result<~[int], ()> = collect(range(0, 3).map(|x| Ok::(x)));
+ assert_eq!(v, Ok(~[0, 1, 2]));
+
+ let v: Result<~[int], int> = collect(range(0, 3)
+ .map(|x| if x > 1 { Err(x) } else { Ok(x) }));
+ assert_eq!(v, Err(2));
// test that it does not take more elements than it needs
let functions = [|| Ok(()), || Err(1), || fail!()];
- assert_eq!(collect(functions.iter().map(|f| (*f)())),
- Err(1));
+ let v: Result<~[()], int> = collect(functions.iter().map(|f| (*f)()));
+ assert_eq!(v, Err(1));
}
#[test]