Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler bootstrap infrastructure and tests should be exercising -g more aggressively #94262

Open
pnkfelix opened this issue Feb 22, 2022 · 0 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

On #93006 a change landed that broke rustc -g for unsized tuples, in a manner that ICE'd the compiler.

We didn't notice that it happened until nearly two weeks later, when #93866 and #93871 were filed.

The reason I'm filing a bug is that we have tests of unsized tuples; even the libcore test suite itself uses them. (I.e., this bug broke my attempts to bootstrap Rust itself with debuginfo-level = 2 in the config.toml. But the test suite itself is not exercising -g enough to observe that combination.

At the very least, PR's that are making changes to debuginfo should be going through the process of bootstrapping with debuginfo-level = 2, as a sanity check.

@pnkfelix pnkfelix added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-testsuite Area: The testsuite used to check the correctness of rustc labels Feb 22, 2022
@wesleywiser wesleywiser added the A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants