Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add an impl for f32::try_from(i32) #64693

Closed
Lokathor opened this issue Sep 22, 2019 · 5 comments
Closed

Request: add an impl for f32::try_from(i32) #64693

Lokathor opened this issue Sep 22, 2019 · 5 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Lokathor
Copy link
Contributor

It appears that there's no TryFrom support on the f32 type.

@jonas-schievink jonas-schievink added C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 22, 2019
@Lokathor
Copy link
Contributor Author

Also, u32, i64, u64, etc

And f64 versions.

@ollie27
Copy link
Member

ollie27 commented Sep 23, 2019

See https://internals.rust-lang.org/t/tryfrom-for-f64/9793

How would it be implemented and what would it be used for?

@scottmcm
Copy link
Member

There's a bunch of disagreement on what the expected semantics of this implementation would be.
See discussion in rust-lang/rfcs#2484

@Lokathor
Copy link
Contributor Author

@ollie27 I understand it's non-trivial. However, that issue is closed up and a lot of people don't even read those forums, so I think an issue about the missing impl is appropriate.

@scottmcm I've actually seen that RFC before long enough ago to have totally forgotten about it. Unfortunately it seems to have stalled.

@scottmcm
Copy link
Member

scottmcm commented Oct 1, 2024

I don't think we track requests like this in rust-repo issues, because there's an infinite list of such things.

People wanting to see stuff happen can try to push on the above RFC, make IRLO threads, talk on zulip, or open an ACP.

@scottmcm scottmcm closed this as completed Oct 1, 2024
@scottmcm scottmcm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants