Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#57428 #61578

Closed
rust-highfive opened this issue Jun 6, 2019 · 2 comments · Fixed by #61582
Closed

rls no longer builds after rust-lang/rust#57428 #61578

rust-highfive opened this issue Jun 6, 2019 · 2 comments · Fixed by #61582
Assignees
@alexreg @Xanewok
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #57428, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @alexreg, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @nikomatsakis,Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2019
@matthiaskrgr matthiaskrgr mentioned this issue Jun 6, 2019
Merged
@matthiaskrgr
Copy link
Member

I'll make an update pr once the two prs currently in the clippy ci queue are merged

@matthiaskrgr matthiaskrgr mentioned this issue Jun 6, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jun 6, 2019
@Centril
Rollup merge of rust-lang#61582 - matthiaskrgr:submodule_upd, r=oli-obk
97a2acd 
submodules: update clippy from 20da8f4 to 71be6f6

Changes:
````
rustup rust-lang#57428
Remove `to_string()`s from CompilerLintFunctions
Fix comment grammar
Fix .map(..).unwrap_or_else(..) bad suggestion
add suggestions for print/write with newline lint
````
Fixes rust-lang#61578
r? @oli-obk
@pnkfelix
Copy link
Member

pnkfelix commented Jun 6, 2019

triage: P-medium. Removing nomination tag.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexreg alexreg

@Xanewok Xanewok

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from 20da8f45 to 71be6f62 matthiaskrgr/rust
5 participants
@alexreg @pnkfelix @matthiaskrgr @Xanewok @rust-highfive