Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type_flags method on ty::Const is a footgun #59209

Closed
oli-obk opened this issue Mar 15, 2019 · 0 comments · Fixed by #59178
Closed

type_flags method on ty::Const is a footgun #59209

oli-obk opened this issue Mar 15, 2019 · 0 comments · Fixed by #59178
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Mar 15, 2019

Related discussion in #59178 (comment)

Basically the type_flags method should be manually inlined into its use sites (and operations that are happening twice should be deduplicated)
@oli-obk oli-obk added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Mar 15, 2019
@oli-obk oli-obk mentioned this issue Mar 15, 2019
Merged
bors added a commit that referenced this issue Mar 17, 2019
@bors
Auto merge of #59178 - oli-obk:lazy_const, r=eddyb
070cebd 
Revert the `LazyConst` PR

The introduction of `LazyConst` did not actually achieve the code simplicity improvements that were the main reason it was introduced. Especially in the presence of const generics, the differences between the "levels of evaluatedness" of a constant become less clear. As it can be seen by the changes in this PR, further simplifications were possible by folding `LazyConst` back into `ConstValue`. We have been able to keep all the advantages gained during the `LazyConst` refactoring (like `const_eval` not returning an interned value, thus making all the `match` code simpler and more performant).

fixes #59209

r? @eddyb @varkor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert the LazyConst PR oli-obk/rust
1 participant
@oli-obk