Build all rust libraries and binaries with "our packaging solution" #5363
Comments
ghost
assigned 
|
Taking this over since I'm working on rustpkg. |
|
@catamorphism getting Servo building using it would probably be a good start just to test out how well it works in a "heavy" development environment. |
|
Nominating for milestone 5, production-ready |
|
accepted for production-ready milestone |
|
Visiting for triage; nothing to add. |
|
Whatever our packaging solution ends up being, we should dog food it as soon as we can. Assigning P-high. Not 1.0 blocker though. |
|
Should this be closed? rustpkg is no more, cargo is doing great (lots of people are using it) and there is #16091 which tracks the specific issue of building rust using cargo. |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this issue
May 2, 2020
add --fix support to `cargo-clippy` Prior to this we had started work on integrating clippy as a subcommand directly into cargo in the form of `cargo clippy-preview` and `cargo fix --clippy`. In the course of that work it was decided that the best approach would be to strictly add the features clippy needed to cargo in order to insert `clippy-driver` only for workspace crates. This was accomplished by adding a `RUSTC_WORKSPACE_WRAPPER` env variable to cargo that will override the normal `RUSTC_WRAPPER` when both are present and the current crate is a workspace crate. This change adds support to clippy to use this by setting the `RUSTC_WORKSPACE_WRAPPER` env variable instead `RUSTC_WRAPPER` and by detecting `--fix` as an arg and swapping out the `check` cargo command for `fix` when it is present. WIP, here are the current issues that I still need to resolve - [x] Detect if we're running on nightly rust - [x] Set `RUSTC_WORKSPACE_WRAPPER` on nightly, and `RUSTC_WRAPPER` on stable - [x] Error out on stable when `--fix` is specified, because stable currently hasn't landed the PR for `RUSTC_WORKSPACE_WRAPPER` so if we set this it just runs check and silently fails - [ ] Update the help text - [ ] The current plan is to shell out to `cargo check --help` and then postprocess the output to mention clippy instead of check where appropriate and to add the extra info about `--fix` and the `-- -A lint` options. - [x] tests? changelog: add `--fix` arg to `cargo-clippy`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should be dogfooding our tools. Turn all of our artifacts into packages and build them with rustpkg.
The text was updated successfully, but these errors were encountered: