Remove crates.io compiler-builtins from the library workspace
#142265
Assignees
Labels
A-compiler-builtins
Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins)
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Comments
rustbot
added
the
needs-triage
tgross35
added
C-cleanup
tgross35
added a commit
to tgross35/rust
that referenced
this issue
Jun 10, 2025
This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
tgross35
added a commit
to tgross35/rust
that referenced
this issue
Jun 10, 2025
This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Jun 11, 2025
…r=Mark-Simulacrum Update dependencies in `library/Cargo.lock` This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
tgross35
added a commit
to tgross35/rust
that referenced
this issue
Jun 11, 2025
This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
tgross35
added a commit
to tgross35/rust
that referenced
this issue
Jun 11, 2025
0.37.0 is a semver-breaking release but the only breakage is in `elf::R_RISCV_GNU_*` and `pe::IMAGE_WEAK_EXTERN_*` constants, as well as Mach-O dyld. This API is not used by `std`, so we should be fine to upgrade. This new version also includes functionality for parsing Wasm object files that we may eventually like to make use of. Also includes the minor bump from 0.37.0 to 0.37.1 to help [1]. Changelog: https://github.com/gimli-rs/object/blob/master/CHANGELOG.md#0370 [1]: rust-lang#142265
tgross35
added a commit
to tgross35/rust
that referenced
this issue
Jun 11, 2025
0.25.0 is a breaking change only because it upgrades the `gimli` version. It also includes a change to the `compiler-builtins` dependency that helps with [1]. Changelog: https://github.com/gimli-rs/addr2line/blob/master/CHANGELOG.md#0250-20250611 [1]: rust-lang#142265
tgross35
added a commit
to tgross35/unwinding
that referenced
this issue
Jun 11, 2025
The breaking change here involves API for `read::Dwarf`, `read::CallFrameInstruction`, and `write::LineProgram`, none of which are used in this crate. Making this change will allow `std` to upgrade to a version of `gimli` that drops the `compiler_builtins` dependency, which is needed for [1]. Changelog: https://github.com/gimli-rs/gimli/blob/master/CHANGELOG.md#0320 [1]: rust-lang/rust#142265
nbdd0121
pushed a commit
to nbdd0121/unwinding
that referenced
this issue
Jun 11, 2025
The breaking change here involves API for `read::Dwarf`, `read::CallFrameInstruction`, and `write::LineProgram`, none of which are used in this crate. Making this change will allow `std` to upgrade to a version of `gimli` that drops the `compiler_builtins` dependency, which is needed for [1]. Changelog: https://github.com/gimli-rs/gimli/blob/master/CHANGELOG.md#0320 [1]: rust-lang/rust#142265
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Jun 12, 2025
…r=Mark-Simulacrum Update dependencies in `library/Cargo.lock` This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Jun 12, 2025
…r=Mark-Simulacrum Update dependencies in `library/Cargo.lock` This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 13, 2025
…r=Mark-Simulacrum Update dependencies in `library/Cargo.lock` This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang#142265
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 13, 2025
…=Mark-Simulacrum Upgrade `object`, `addr2line`, and `unwinding` in the standard library Object: 0.37.0 is a semver-breaking release but the only breakage is in `elf::R_RISCV_GNU_*` and `pe::IMAGE_WEAK_EXTERN_*` constants, as well as Mach-O dyld. This API is not used by `std`, so we should be fine to upgrade. This new version also includes functionality for parsing Wasm object files that we may eventually like to make use of. Changelog: https://github.com/gimli-rs/object/blob/master/CHANGELOG.md#0370 Addr2line: 0.25.0 is a breaking change only because it upgrades the `gimli` version. It also includes a change to the `compiler-builtins` dependency that helps with [1]. Changelog: https://github.com/gimli-rs/addr2line/blob/master/CHANGELOG.md#0250-20250611 [1]: rust-lang#142265
rust-timer
added a commit
that referenced
this issue
Jun 13, 2025
Rollup merge of #142308 - tgross35:upgrade-library-object, r=Mark-Simulacrum Upgrade `object`, `addr2line`, and `unwinding` in the standard library Object: 0.37.0 is a semver-breaking release but the only breakage is in `elf::R_RISCV_GNU_*` and `pe::IMAGE_WEAK_EXTERN_*` constants, as well as Mach-O dyld. This API is not used by `std`, so we should be fine to upgrade. This new version also includes functionality for parsing Wasm object files that we may eventually like to make use of. Changelog: https://github.com/gimli-rs/object/blob/master/CHANGELOG.md#0370 Addr2line: 0.25.0 is a breaking change only because it upgrades the `gimli` version. It also includes a change to the `compiler-builtins` dependency that helps with [1]. Changelog: https://github.com/gimli-rs/addr2line/blob/master/CHANGELOG.md#0250-20250611 [1]: #142265
tgross35
added a commit
to tgross35/unwinding
that referenced
this issue
Jun 13, 2025
Since [1] the crates.io version of `compiler-builtins` is no longer needed as part of `rustc-dep-of-std`, so remove it here. [1]: rust-lang/rust#142265
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this issue
Jun 14, 2025
…mulacrum Update dependencies in `library/Cargo.lock` This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1]. [1]: rust-lang/rust#142265
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this issue
Jun 14, 2025
…ulacrum Upgrade `object`, `addr2line`, and `unwinding` in the standard library Object: 0.37.0 is a semver-breaking release but the only breakage is in `elf::R_RISCV_GNU_*` and `pe::IMAGE_WEAK_EXTERN_*` constants, as well as Mach-O dyld. This API is not used by `std`, so we should be fine to upgrade. This new version also includes functionality for parsing Wasm object files that we may eventually like to make use of. Changelog: https://github.com/gimli-rs/object/blob/master/CHANGELOG.md#0370 Addr2line: 0.25.0 is a breaking change only because it upgrades the `gimli` version. It also includes a change to the `compiler-builtins` dependency that helps with [1]. Changelog: https://github.com/gimli-rs/addr2line/blob/master/CHANGELOG.md#0250-20250611 [1]: rust-lang/rust#142265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
After #141993 we should eliminate
compiler-builtinsfrom any crates that are depending on it via crates.io to remove the duplicate dependency so the patch isn't needed. Todo list, taken from the PR:compiler-builtinsfromrustc-dep-of-stddependencies stdarch#1825compiler-builtinsfromrustc-dep-of-stddependencies rustc-demangle#80 released in v0.1.25compiler-builtinsfromrustc-dep-of-stddependencies cfg-if#84 released in v1.0.1compiler-builtinsfromrustc-dep-of-stddependencies unicode-rs/unicode-width#77 released in v0.2.1compiler-builtinsfromrustc-dep-of-stddependencies alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx) released in v0.2.9compiler-builtinsfromrustc-dep-of-stddependencies gimli-rs/gimli#769 released in v0.32.0compiler-builtinsfromrustc-dep-of-stddependencies r-efi/r-efi#89 (efi)compiler-builtinsfromrustc-dep-of-stddependencies r-efi/r-efi-alloc#9 (efi)compiler-builtinsfromrustc-dep-of-stddependencies fortanix/rust-sgx#770 (sgx)compiler-builtinsfromrustc-dep-of-stddependencies hermit-os/hermit-rs#718 (hermit) released in v0.5.2compiler-builtinsfromrustc-dep-of-stddependencies bytecodealliance/wasi-rs#108 (wasi) released in v0.11.1 (we are on the 0.11.x release cycle)compiler-builtinsfromrustc-dep-of-stddependencies gimli-rs/addr2line#345 released in v0.25.0compiler-builtinsfromrustc-dep-of-stddependencies oyvindln/adler2#2 released in v2.0.1compiler-builtinsfromrustc-dep-of-stddependencies BurntSushi/memchr#180 released in v2.7.5compiler-builtinsfromrustc-dep-of-stddependencies Frommi/miniz_oxide#173 released in v0.8.9compiler-builtinsfromrustc-dep-of-stddependencies gimli-rs/object#777 released in v0.37.1ruzstd,object, andaddr2lineto the latest versions backtrace-rs#718gimlito 0.32.0 nbdd0121/unwinding#48 released in v0.2.7compiler_builtinsdependency nbdd0121/unwinding#49Updates in rust-lang/rust:
library/Cargo.lock#142276object,addr2line, andunwindingin the standard library #142308The text was updated successfully, but these errors were encountered: