Skip to content

after stage0 redesign, x check defaults to building the compiler #141902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyn514 opened this issue Jun 2, 2025 · 0 comments · Fixed by #141914
Closed

after stage0 redesign, x check defaults to building the compiler #141902

jyn514 opened this issue Jun 2, 2025 · 0 comments · Fixed by #141914
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 2, 2025

Summary

since #119899, x check has a global default of --stage 1. that makes builds for the default and compiler profiles much slower, because they are building the compiler before checking std.

we should do the following things:

  • profile = "compiler" should set check-stage = 0 (this should be an easy change in defaults/compiler.toml)
  • maybe the global default should also do that?
  • x check --stage 0 std should give a warning if it doesn't already

note that after my suggested change, x check without arguments will no longer check the standard library for compiler profile. that seems ~fine.

reported in #t-infra/bootstrap > Stage 0 std redesign support thread @ 💬.

Command used

./x.py check

Expected behaviour

x check is a ~fast operation, like before.

Actual behaviour

x check takes about twice as long (because it defaults to --stage 1, which builds the compiler)

Bootstrap configuration (bootstrap.toml)

cp config.example.toml config.toml

Operating system

HEAD

52882f6

Additional context

Build Log

<log>

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jun 2, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 2, 2025
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 2, 2025
@bors bors closed this as completed in 72f60fb Jun 3, 2025
rust-timer added a commit that referenced this issue Jun 3, 2025
Rollup merge of #141914 - onur-ozkan:follow-ups, r=Kobzol

redesign stage 0 std follow-ups

Various follow-ups pointed out on Zulip during post-merge discussions of [redesign stage 0 std #119899](#119899).

r? `@jieyouxu`

Fixes #141902.
Fixes #141905.

cc `@jyn514`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants