Compiling without correct target generates confusing tuple variant error messages #117640
Labels
C-bug
Category: This is a bug.
Comments
rustbot
added
the
needs-triage
|
This is a duplicate of #97685 I think the dependencies that compiled correctly are build-dependencies, and they compiled fine because they were compiled for the host. |
saethlin
removed
the
needs-triage
|
Thanks for the triage! We can close this in favor of that one. My issue is linked so people can see the output. |
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this issue
Nov 9, 2023
…text In order to compile buildpacks, users need to have both the musl toolchain and the Rust target installed. If the musl toolchain is missing, we already showed help text that says what packages need to be installed. However, this help text did not mention the Rust target, meaning after installing the musl tools, users would then go on to receive another error - this time from the Rust compiler. Whilst the Rust compiler error message does suggest running the `rustup target add` command itself: - this suggestion is often lost in the noise: rust-lang/rust#117640 - it means the users has had two failed attempts in a row, which could make the experience feel open-ended/frustrating Now, the cross-compile assistance help text also suggests the `rustup target add` step, improving the UX slightly. The help texts are starting to include a fair bit of duplication, however, refactoring is covered by the separate #727. Fixes #716. GUS-W-14438920.
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this issue
Nov 9, 2023
…text (#729) In order to compile buildpacks, users need to have both the musl toolchain and the Rust target installed. If the musl toolchain is missing, we already show help text that says what packages need to be installed. However, this help text did not mention the Rust target, meaning after installing the musl tools, users would then go on to receive another error - this time from the Rust compiler. Whilst the Rust compiler error message does suggest running the `rustup target add` command itself: - this suggestion is often lost in the noise: rust-lang/rust#117640 - it means the users has had two failed attempts in a row, which could make the experience feel open-ended/frustrating Now, the cross-compile assistance help text also suggests the `rustup target add` step, improving the UX slightly. The help texts are starting to include a fair bit of duplication, however, refactoring is covered by the separate #727. Fixes #716. GUS-W-14438920.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to #65386, I hit a bunch of errors when compiling a project on a new machine. It turns out it was due to the target not being added to rustup, however, that information was somewhat hidden. Details below.
Expected
If core cannot be found that this would halt compilation or that this suggestion would be found at the bottom of the compilation:
Actual
When I compiled code I hit a flood of these error messages:
And
And
I'm talking hundreds upon hundreds of lines of errors. They pushed the relevant warning which was at the top WAYYY far off screen:
Which contains the correct suggestion, but it's very well hidden in the output. Weirdly it looked like a lot of dependencies compiled correctly, and tests ran (even though they reported 0 results). Then 193 lines down it gives the correct suggestion
Meta
rustc --version --verbose:The text was updated successfully, but these errors were encountered: