Suppress suggestions while span is in external library

Signed-off-by: xizheyin <[email protected]>

Author: xizheyin

compiler/rustc_errors/src/emitter.rs

@@ -1996,6 +1996,14 @@ impl HumanEmitter {
             return Ok(());
         };
 
+        if suggestion
+            .substitutions
+            .iter()
+            .any(|s| s.parts.iter().any(|p| is_external_library(sm, p.span)))
+        {
+            return Ok(());
+        }
+
         // Render the replacements for each suggestion
         let suggestions = suggestion.splice_lines(sm);
         debug!(?suggestions);
@@ -3532,3 +3540,13 @@ pub(crate) fn should_show_source_code(
         .map(|path| ignored_directories.iter().all(|dir| !path.starts_with(dir)))
         .unwrap_or(true)
 }
+
+fn is_external_library(sm: &SourceMap, span: Span) -> bool {
+    let filename = sm.span_to_filename(span);
+    if let Some(path) = filename.into_local_path() {
+        path.to_string_lossy().contains(".cargo/registry/src/")
+            || path.to_string_lossy().contains(".rustup/toolchains/")
+    } else {
+        false
+    }
+}

compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs

@@ -449,10 +449,6 @@ impl<'a, 'tcx> TypeErrCtxt<'a, 'tcx> {
         err: &mut Diag<'_>,
         trait_pred: ty::PolyTraitPredicate<'tcx>,
     ) -> bool {
-        if obligation.cause.span.in_external_macro(self.infcx.tcx.sess.source_map()) {
-            return false;
-        }
-
         let mut code = obligation.cause.code();
         if let ObligationCauseCode::FunctionArg { arg_hir_id, call_hir_id, .. } = code
             && let Some(typeck_results) = &self.typeck_results