From 1ff7f04120f11e4d15a6dad40417551873bf8ff2 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sun, 1 Jul 2018 00:27:44 +0200 Subject: [PATCH 1/3] Fix rustdoc run failures by shutting down definitely some lints --- src/librustc/lint/levels.rs | 5 +++++ src/librustc/session/mod.rs | 6 +++++- src/librustdoc/core.rs | 9 ++++++++- src/test/rustdoc-ui/unused.rs | 24 ++++++++++++++++++++++++ 4 files changed, 42 insertions(+), 2 deletions(-) create mode 100644 src/test/rustdoc-ui/unused.rs diff --git a/src/librustc/lint/levels.rs b/src/librustc/lint/levels.rs index 3393a2bf89d4b..f8676a3e7a113 100644 --- a/src/librustc/lint/levels.rs +++ b/src/librustc/lint/levels.rs @@ -118,6 +118,11 @@ impl LintLevelSets { // Ensure that we never exceed the `--cap-lints` argument. level = cmp::min(level, self.lint_cap); + if let Some(driver_level) = sess.driver_lint_caps.get(&LintId::of(lint)) { + // Ensure that we never exceed driver level. + level = cmp::min(*driver_level, level); + } + return (level, src) } diff --git a/src/librustc/session/mod.rs b/src/librustc/session/mod.rs index 076d56fb80842..180c5867e93d8 100644 --- a/src/librustc/session/mod.rs +++ b/src/librustc/session/mod.rs @@ -22,7 +22,7 @@ use middle::dependency_format; use session::search_paths::PathKind; use session::config::{OutputType}; use ty::tls; -use util::nodemap::{FxHashSet}; +use util::nodemap::{FxHashMap, FxHashSet}; use util::common::{duration_to_secs_str, ErrorReported}; use util::common::ProfileQueriesMsg; @@ -160,6 +160,9 @@ pub struct Session { /// Metadata about the allocators for the current crate being compiled pub has_global_allocator: Once, + + /// Cap lint level specified by a driver specifically. + pub driver_lint_caps: FxHashMap, } pub struct PerfStats { @@ -1164,6 +1167,7 @@ pub fn build_session_( (*GLOBAL_JOBSERVER).clone() }, has_global_allocator: Once::new(), + driver_lint_caps: FxHashMap(), }; sess diff --git a/src/librustdoc/core.rs b/src/librustdoc/core.rs index ddc9bdb384c0b..5cfdd07ab9204 100644 --- a/src/librustdoc/core.rs +++ b/src/librustdoc/core.rs @@ -235,6 +235,14 @@ pub fn run_core(search_paths: SearchPaths, let mut sess = session::build_session_( sessopts, cpath, diagnostic_handler, codemap, ); + + let shutdown_lints = [lint::builtin::UNUSED_IMPORTS, + lint::builtin::UNUSED_EXTERN_CRATES]; + + for l in &shutdown_lints { + sess.driver_lint_caps.insert(lint::LintId::of(l), lint::Allow); + } + let codegen_backend = rustc_driver::get_codegen_backend(&sess); let cstore = Rc::new(CStore::new(codegen_backend.metadata_loader())); rustc_lint::register_builtins(&mut sess.lint_store.borrow_mut(), Some(&sess)); @@ -299,7 +307,6 @@ pub fn run_core(search_paths: SearchPaths, &sess); let resolver = RefCell::new(resolver); - abort_on_err(driver::phase_3_run_analysis_passes(&*codegen_backend, control, &sess, diff --git a/src/test/rustdoc-ui/unused.rs b/src/test/rustdoc-ui/unused.rs new file mode 100644 index 0000000000000..8b53098639232 --- /dev/null +++ b/src/test/rustdoc-ui/unused.rs @@ -0,0 +1,24 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-pass + +// This test purpose is to check that unused_imports lint isn't fired +// by rustdoc. Why would it? Because when rustdoc is running, it uses +// "everybody-loops" which replaces parts of code with "loop {}" to get +// huge performance improvements. + +#![deny(unused_imports)] + +use std::fs::File; + +pub fn f() { + let _: File; +} From 92cda8c7da86b6770a483bc45ce32c8b94b019ec Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Thu, 5 Jul 2018 20:06:33 +0200 Subject: [PATCH 2/3] Whitelist lints --- src/librustc_lint/builtin.rs | 2 +- src/librustc_lint/lib.rs | 2 +- src/librustdoc/core.rs | 23 +++++++++++++++++------ 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index c5f3b45950ed7..d6e5c70b8f7e1 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -280,7 +280,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnsafeCode { } declare_lint! { - MISSING_DOCS, + pub MISSING_DOCS, Allow, "detects missing documentation for public members" } diff --git a/src/librustc_lint/lib.rs b/src/librustc_lint/lib.rs index adc700506ffc0..459f496c9fe05 100644 --- a/src/librustc_lint/lib.rs +++ b/src/librustc_lint/lib.rs @@ -56,7 +56,7 @@ use lint::LintId; use lint::FutureIncompatibleInfo; mod bad_style; -mod builtin; +pub mod builtin; mod types; mod unused; diff --git a/src/librustdoc/core.rs b/src/librustdoc/core.rs index 5cfdd07ab9204..c7a8e6804f6c9 100644 --- a/src/librustdoc/core.rs +++ b/src/librustdoc/core.rs @@ -189,6 +189,7 @@ pub fn run_core(search_paths: SearchPaths, let intra_link_resolution_failure_name = lint::builtin::INTRA_DOC_LINK_RESOLUTION_FAILURE.name; let warnings_lint_name = lint::builtin::WARNINGS.name; + let missing_docs = rustc_lint::builtin::MISSING_DOCS.name; let lints = lint::builtin::HardwiredLints.get_lints() .into_iter() .chain(rustc_lint::SoftLints.get_lints().into_iter()) @@ -236,12 +237,22 @@ pub fn run_core(search_paths: SearchPaths, sessopts, cpath, diagnostic_handler, codemap, ); - let shutdown_lints = [lint::builtin::UNUSED_IMPORTS, - lint::builtin::UNUSED_EXTERN_CRATES]; - - for l in &shutdown_lints { - sess.driver_lint_caps.insert(lint::LintId::of(l), lint::Allow); - } + lint::builtin::HardwiredLints.get_lints() + .into_iter() + .chain(rustc_lint::SoftLints.get_lints().into_iter()) + .filter_map(|lint| { + if lint.name == warnings_lint_name || + lint.name == intra_link_resolution_failure_name || + lint.name == missing_docs { + None + } else { + Some(lint) + } + }) + .for_each(|l| { + sess.driver_lint_caps.insert(lint::LintId::of(l), + lint::Allow); + }); let codegen_backend = rustc_driver::get_codegen_backend(&sess); let cstore = Rc::new(CStore::new(codegen_backend.metadata_loader())); From 66beb4e5b4fe9b8dd5aa29c4bc8c775825a3b5e4 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Mon, 9 Jul 2018 18:10:08 +0200 Subject: [PATCH 3/3] add comment about lints whitelisting --- src/librustdoc/core.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/librustdoc/core.rs b/src/librustdoc/core.rs index c7a8e6804f6c9..f1ec82e0783fc 100644 --- a/src/librustdoc/core.rs +++ b/src/librustdoc/core.rs @@ -241,6 +241,8 @@ pub fn run_core(search_paths: SearchPaths, .into_iter() .chain(rustc_lint::SoftLints.get_lints().into_iter()) .filter_map(|lint| { + // We don't want to whitelist *all* lints so let's + // ignore those ones. if lint.name == warnings_lint_name || lint.name == intra_link_resolution_failure_name || lint.name == missing_docs {