Skip to content

Commit 7669d50

Browse files
committed
add a FIXME
Signed-off-by: onur-ozkan <[email protected]>
1 parent 8290766 commit 7669d50

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/bootstrap/src/core/builder/cargo.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,7 @@ impl Cargo {
112112
let mut cargo = builder.cargo(compiler, mode, source_type, target, cmd_kind);
113113

114114
match cmd_kind {
115-
// No need to configure the target linker for these command types,
116-
// as they don't invoke rustc at all.
115+
// No need to configure the target linker for these command types.
117116
Kind::Clean | Kind::Check | Kind::Suggest | Kind::Format | Kind::Setup => {}
118117
_ => {
119118
cargo.configure_linker(builder);
@@ -205,6 +204,8 @@ impl Cargo {
205204
self
206205
}
207206

207+
// FIXME(onur-ozkan): Add coverage to make sure modifications to this function
208+
// doesn't cause cache invalidations (e.g., #130108).
208209
fn configure_linker(&mut self, builder: &Builder<'_>) -> &mut Cargo {
209210
let target = self.target;
210211
let compiler = self.compiler;

0 commit comments

Comments
 (0)