use a HashSet instead of IndexSet for cache of types with notable trait impls

iteration order shouldn't matter

Author: yotamofek

src/librustdoc/html/render/context.rs

@@ -5,7 +5,7 @@ use std::path::{Path, PathBuf};
 use std::sync::mpsc::{Receiver, channel};
 
 use rinja::Template;
-use rustc_data_structures::fx::{FxHashMap, FxHashSet, FxIndexMap, FxIndexSet};
+use rustc_data_structures::fx::{FxHashMap, FxHashSet, FxIndexMap};
 use rustc_hir::def_id::{DefIdMap, LOCAL_CRATE};
 use rustc_middle::ty::TyCtxt;
 use rustc_session::Session;
@@ -60,7 +60,7 @@ pub(crate) struct Context<'tcx> {
     /// [#82381]: https://github.com/rust-lang/rust/issues/82381
     pub(crate) shared: SharedContext<'tcx>,
     /// Collection of all types with notable traits referenced in the current module.
-    pub(crate) types_with_notable_traits: RefCell<FxIndexSet<clean::Type>>,
+    pub(crate) types_with_notable_traits: RefCell<FxHashSet<clean::Type>>,
     /// Contains information that needs to be saved and reset after rendering an item which is
     /// not a module.
     pub(crate) info: ContextInfo,
@@ -579,7 +579,7 @@ impl<'tcx> FormatRenderer<'tcx> for Context<'tcx> {
             id_map: RefCell::new(id_map),
             deref_id_map: Default::default(),
             shared: scx,
-            types_with_notable_traits: RefCell::new(FxIndexSet::default()),
+            types_with_notable_traits: RefCell::default(),
             info: ContextInfo::new(include_sources),
         };
 

src/librustdoc/html/render/print_item.rs

@@ -278,11 +278,10 @@ pub(super) fn print_item(cx: &Context<'_>, item: &clean::Item, buf: &mut Buffer)
     // Render notable-traits.js used for all methods in this module.
     let mut types_with_notable_traits = cx.types_with_notable_traits.borrow_mut();
     if !types_with_notable_traits.is_empty() {
-        write!(
-            buf,
-            r#"<script type="text/json" id="notable-traits-data">{}</script>"#,
+        write!(buf, r#"<script type="text/json" id="notable-traits-data">{}</script>"#, {
+            #[allow(rustc::potential_query_instability)]
             notable_traits_json(types_with_notable_traits.iter(), cx)
-        );
+        });
         types_with_notable_traits.clear();
     }
 }