Remove redundant check_def_id

mu001999 · mu001999 · commit 6f9eb9fc705a · 2023-11-25T23:48:16.000+08:00
diff --git a/compiler/rustc_passes/src/dead.rs b/compiler/rustc_passes/src/dead.rs
@@ -384,6 +384,7 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {
                             && let ItemKind::Impl(impl_ref) =
                                 self.tcx.hir().expect_item(local_def_id).kind
                         {
+                            // FIXME: only walk bounds
                             intravisit::walk_generics(self, impl_ref.generics);
                         }
                     }
@@ -404,7 +405,6 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {
                             && let ItemKind::Impl(impl_ref) =
                                 self.tcx.hir().expect_item(impl_def_id).kind
                         {
-                            self.check_def_id(impl_def);
                             for impl_item in impl_ref.items {
                                 if Some(def_id) == impl_item.trait_item_def_id {
                                     self.check_def_id(impl_item.id.owner_id.to_def_id());

Original file line number	Diff line number	Diff line change
`@@ -384,6 +384,7 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {`
`384`	`384`	`&& let ItemKind::Impl(impl_ref) =`
`385`	`385`	`self.tcx.hir().expect_item(local_def_id).kind`
`386`	`386`	`{`
	`387`	`+ // FIXME: only walk bounds`
`387`	`388`	`intravisit::walk_generics(self, impl_ref.generics);`
`388`	`389`	`}`
`389`	`390`	`}`
`@@ -404,7 +405,6 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {`
`404`	`405`	`&& let ItemKind::Impl(impl_ref) =`
`405`	`406`	`self.tcx.hir().expect_item(impl_def_id).kind`
`406`	`407`	`{`
`407`		`- self.check_def_id(impl_def);`
`408`	`408`	`for impl_item in impl_ref.items {`
`409`	`409`	`if Some(def_id) == impl_item.trait_item_def_id {`
`410`	`410`	`self.check_def_id(impl_item.id.owner_id.to_def_id());`