Auto merge of #51035 - oli-obk:unsupported_crate_type, r=eddyb

Don't ICE if crate has no valid crate types left

fixes #50993

Author: bors

src/librustc_codegen_llvm/base.rs

@@ -642,7 +642,7 @@ fn write_metadata<'a, 'gcx>(tcx: TyCtxt<'a, 'gcx, 'gcx>,
             config::CrateTypeDylib |
             config::CrateTypeProcMacro => MetadataKind::Compressed,
         }
-    }).max().unwrap();
+    }).max().unwrap_or(MetadataKind::None);
 
     if kind == MetadataKind::None {
         return (metadata_llcx,

src/test/ui/issue-50993.rs

@@ -0,0 +1,18 @@
+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: --crate-type dylib --target thumbv7em-none-eabihf
+// compile-pass
+// error-pattern: dropping unsupported crate type `dylib` for target `thumbv7em-none-eabihf`
+
+#![feature(no_core)]
+
+#![no_std]
+#![no_core]

src/test/ui/issue-50993.stderr

@@ -0,0 +1,2 @@
+warning: dropping unsupported crate type `dylib` for target `thumbv7em-none-eabihf`
+