Skip to content

Commit 63a51a6

Browse files
saethlinRalfJung
andauthored
Explain why we save spans for some memory types and not others
Co-authored-by: Ralf Jung <[email protected]>
1 parent 1852bb8 commit 63a51a6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/tools/miri/src/machine.rs

+2
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ impl MiriMemoryKind {
140140
fn should_save_allocation_span(self) -> bool {
141141
use self::MiriMemoryKind::*;
142142
match self {
143+
// Heap allocations are fine since the `Allocation` is created immediately.
143144
Rust | Miri | C | Mmap => true,
145+
// Everything else is unclear, let's not show potentially confusing spans.
144146
Machine | Global | ExternStatic | Tls | WinHeap | Runtime => false,
145147
}
146148
}

0 commit comments

Comments
 (0)