Skip to content

Commit 1a740c3

Browse files
committed
Auto merge of #117138 - zachs18:rwlock_guard_debug_unsized, r=dtolnay
Add T: ?Sized to `RwLockReadGuard` and `RwLockWriteGuard`'s Debug impls. For context, `MutexGuard` has `+ ?Sized` on its `Debug` impl, and all three have `+ ?Sized` on their `Display` impls. It looks like the `?Sized` was just missed when the impls were added (the impl for `MutexGuard` was added in the same PR (#38006) with support for `T: Debug + ?Sized`, and `RwLock*Guard`s did allow `T: ?Sized` types already); the `Display` impls were added later (#42822) with support for `T: Debug + ?Sized` types. I think this needs a T-libs-api FCP? I'm not sure if this also needs an ACP. If so I can make one. These are changes to (stable) trait impls on stable types so will be insta-stable. `@rustbot` label +T-libs-api
2 parents 82b804c + 9e3c9a6 commit 1a740c3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

library/std/src/sync/rwlock.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ impl<'rwlock, T: ?Sized> RwLockWriteGuard<'rwlock, T> {
532532
}
533533

534534
#[stable(feature = "std_debug", since = "1.16.0")]
535-
impl<T: fmt::Debug> fmt::Debug for RwLockReadGuard<'_, T> {
535+
impl<T: ?Sized + fmt::Debug> fmt::Debug for RwLockReadGuard<'_, T> {
536536
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
537537
(**self).fmt(f)
538538
}
@@ -546,7 +546,7 @@ impl<T: ?Sized + fmt::Display> fmt::Display for RwLockReadGuard<'_, T> {
546546
}
547547

548548
#[stable(feature = "std_debug", since = "1.16.0")]
549-
impl<T: fmt::Debug> fmt::Debug for RwLockWriteGuard<'_, T> {
549+
impl<T: ?Sized + fmt::Debug> fmt::Debug for RwLockWriteGuard<'_, T> {
550550
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
551551
(**self).fmt(f)
552552
}

0 commit comments

Comments
 (0)