Skip to content

Commit 03dfa64

Browse files
committed
lints: promote levels.rs to lint.rs & extract passes.rs
1 parent 16bf278 commit 03dfa64

File tree

9 files changed

+21
-16
lines changed

9 files changed

+21
-16
lines changed

src/librustc/lint/levels.rs renamed to src/librustc/lint.rs

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
use std::cmp;
22

33
use crate::ich::StableHashingContext;
4-
use crate::lint::context::{CheckLintNameResult, LintStore};
4+
use crate::lint::context::CheckLintNameResult;
55
use rustc_data_structures::fx::FxHashMap;
66
use rustc_data_structures::stable_hasher::{HashStable, StableHasher};
77
use rustc_errors::{struct_span_err, Applicability, DiagnosticBuilder, DiagnosticId};
88
use rustc_hir::HirId;
9-
use rustc_session::lint::{builtin, Level, Lint, LintId};
9+
pub use rustc_session::lint::{builtin, Level, Lint, LintId, LintPass};
1010
use rustc_session::{DiagnosticMessageId, Session};
1111
use rustc_span::hygiene::MacroKind;
1212
use rustc_span::source_map::{DesugaringKind, ExpnKind, MultiSpan};
@@ -19,6 +19,14 @@ use syntax::sess::feature_err;
1919

2020
use rustc_error_codes::*;
2121

22+
mod context;
23+
pub mod internal;
24+
mod passes;
25+
26+
pub use context::add_elided_lifetime_in_path_suggestion;
27+
pub use context::{EarlyContext, LateContext, LintContext, LintStore};
28+
pub use passes::{EarlyLintPass, EarlyLintPassObject, LateLintPass, LateLintPassObject};
29+
2230
/// How a lint level was set.
2331
#[derive(Clone, Copy, PartialEq, Eq, HashStable)]
2432
pub enum LintSource {

src/librustc/lint/context.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
use self::TargetLint::*;
1818

1919
use crate::hir::map::definitions::{DefPathData, DisambiguatedDefPathData};
20-
use crate::lint::levels::LintLevelsBuilder;
21-
use crate::lint::{EarlyLintPassObject, LateLintPassObject};
20+
use crate::lint::passes::{EarlyLintPassObject, LateLintPassObject};
21+
use crate::lint::LintLevelsBuilder;
2222
use crate::middle::privacy::AccessLevels;
2323
use crate::middle::stability;
2424
use crate::ty::layout::{LayoutError, LayoutOf, TyLayout};

src/librustc/lint/internal.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
//! Some lints that are only useful in the compiler or crates that use compiler internals, such as
22
//! Clippy.
33
4-
use crate::lint::{EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintContext};
4+
use crate::lint::context::{EarlyContext, LateContext, LintContext};
5+
use crate::lint::passes::{EarlyLintPass, LateLintPass};
56
use rustc_data_structures::fx::FxHashMap;
67
use rustc_errors::Applicability;
78
use rustc_hir::{GenericArg, HirId, MutTy, Mutability, Path, PathSegment, QPath, Ty, TyKind};

src/librustc/lint/mod.rs renamed to src/librustc/lint/passes.rs

+1-7
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
//! example) requires more effort. See `emit_lint` and `GatherNodeLevels`
1919
//! in `context.rs`.
2020
21-
pub use self::levels::LintSource::{self, *};
2221
pub use self::Level::*;
22+
pub use crate::lint::LintSource::{self, *};
2323

2424
use rustc_data_structures::sync;
2525
use rustc_hir as hir;
@@ -308,9 +308,3 @@ macro_rules! declare_combined_early_lint_pass {
308308
pub type EarlyLintPassObject = Box<dyn EarlyLintPass + sync::Send + sync::Sync + 'static>;
309309
pub type LateLintPassObject =
310310
Box<dyn for<'a, 'tcx> LateLintPass<'a, 'tcx> + sync::Send + sync::Sync + 'static>;
311-
312-
mod context;
313-
pub mod internal;
314-
mod levels;
315-
316-
pub use self::levels::{struct_lint_level, LintLevelMap, LintLevelSets, LintLevelsBuilder};

src/librustc/mir/interpret/error.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ impl<'tcx> ConstEvalErr<'tcx> {
154154
.next()
155155
.unwrap_or(lint_root);
156156
tcx.struct_span_lint_hir(
157-
crate::rustc::lint::builtin::CONST_ERR,
157+
rustc_session::lint::builtin::CONST_ERR,
158158
hir_id,
159159
tcx.span,
160160
message,

src/librustc_lint/array_into_iter.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
use rustc::lint::{FutureIncompatibleInfo, LateContext, LateLintPass, LintContext};
1+
use rustc::lint::{LateContext, LateLintPass, LintContext};
22
use rustc::ty;
33
use rustc::ty::adjustment::{Adjust, Adjustment};
44
use rustc_errors::Applicability;
55
use rustc_hir as hir;
6+
use rustc_session::lint::FutureIncompatibleInfo;
67
use rustc_span::symbol::sym;
78

89
declare_lint! {

src/librustc_passes/dead.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// from live codes are live, and everything else is dead.
44

55
use rustc::hir::map::Map;
6-
use rustc::lint;
76
use rustc::middle::codegen_fn_attrs::CodegenFnAttrFlags;
87
use rustc::middle::privacy;
98
use rustc::ty::{self, DefIdTree, TyCtxt};
@@ -14,6 +13,7 @@ use rustc_hir::def_id::{DefId, LOCAL_CRATE};
1413
use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor};
1514
use rustc_hir::itemlikevisit::ItemLikeVisitor;
1615
use rustc_hir::{Node, PatKind, TyKind};
16+
use rustc_session::lint;
1717

1818
use rustc_span;
1919
use rustc_span::symbol::sym;

src/librustdoc/core.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use rustc::lint;
21
use rustc::middle::cstore::CrateStore;
32
use rustc::middle::privacy::AccessLevels;
43
use rustc::session::config::ErrorOutputType;
@@ -14,6 +13,7 @@ use rustc_hir::HirId;
1413
use rustc_interface::interface;
1514
use rustc_lint;
1615
use rustc_resolve as resolve;
16+
use rustc_session::lint;
1717

1818
use rustc_errors::emitter::{Emitter, EmitterWriter};
1919
use rustc_errors::json::JsonEmitter;

src/librustdoc/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ extern crate rustc_metadata;
3636
extern crate rustc_mir;
3737
extern crate rustc_parse;
3838
extern crate rustc_resolve;
39+
extern crate rustc_session;
3940
extern crate rustc_span as rustc_span;
4041
extern crate rustc_target;
4142
extern crate rustc_typeck;

0 commit comments

Comments
 (0)