Skip to content

relicensing broke rust x.py dist #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthiaskrgr opened this issue Oct 13, 2018 · 4 comments
Closed

relicensing broke rust x.py dist #3311

matthiaskrgr opened this issue Oct 13, 2018 · 4 comments

Comments

@matthiaskrgr
Copy link
Member

I tried updating the submodulei in rust-lang/rust#54916 but ./x.py dist fails with up to date clippy submodule

Building stage2 tool cargo-clippy (x86_64-pc-windows-msvc)
    Finished release [optimized] target(s) in 0.74s
[TIMING] ToolBuild { compiler: Compiler { stage: 2, host: "x86_64-pc-windows-msvc" }, target: "x86_64-pc-windows-msvc", tool: "cargo-clippy", path: "src/tools/clippy", mode: ToolRustc, is_optional_tool: true, source_type: Submodule, extra_features: [] } -- 0.893
thread 'main' panicked at 'fs::File::open(&src) failed with The system cannot find the file specified. (os error 2)', bootstrap\lib.rs:1291:25
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failed to run: C:\projects\rust\build\bootstrap\debug\bootstrap dist
Build completed unsuccessfully in 1:13:05
Command exited with code 1
set PATH=%PATH%;"C:\Program Files (x86)\Windows Kits\10\Debuggers\X64"
if exist %LOCALAPPDATA%\CrashDumps for %%f in (%LOCALAPPDATA%\CrashDumps\*) do cdb -c "k;q" -G -z "%%f"

I bisected this to ca437e8

@matthiaskrgr
Copy link
Member Author

Note: readding an empty LICENSE file fixes the dist build.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 13, 2018

Ah, we need to fix this on the rustc side. There's some code in src/bootstrap/dist.rs that explicitly copies LICENSE for clippy.

@matthiaskrgr
Copy link
Member Author

Ok, I tweaked the run() function to point to the new files, now waiting for the build to finish :)

@matthiaskrgr
Copy link
Member Author

Updated the pr via rust-lang/rust@9c651b3
I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants