Fix extra_unused_lifetimes false positive

smoelius · smoelius · commit 87eded6500f1 · 2022-06-22T20:21:04.000-04:00
diff --git a/clippy_lints/src/lifetimes.rs b/clippy_lints/src/lifetimes.rs
@@ -92,7 +92,9 @@ impl<'tcx> LateLintPass<'tcx> for Lifetimes {
         if let ItemKind::Fn(ref sig, generics, id) = item.kind {
             check_fn_inner(cx, sig.decl, Some(id), None, generics, item.span, true);
         } else if let ItemKind::Impl(impl_) = item.kind {
-            report_extra_impl_lifetimes(cx, impl_);
+            if !item.span.from_expansion() {
+                report_extra_impl_lifetimes(cx, impl_);
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,9 @@ impl<'tcx> LateLintPass<'tcx> for Lifetimes {`
`92`	`92`	`if let ItemKind::Fn(ref sig, generics, id) = item.kind {`
`93`	`93`	`check_fn_inner(cx, sig.decl, Some(id), None, generics, item.span, true);`
`94`	`94`	`} else if let ItemKind::Impl(impl_) = item.kind {`
`95`		`- report_extra_impl_lifetimes(cx, impl_);`
	`95`	`+ if !item.span.from_expansion() {`
	`96`	`+ report_extra_impl_lifetimes(cx, impl_);`
	`97`	`+ }`
`96`	`98`	`}`
`97`	`99`	`}`
`98`	`100`