Skip to content

Commit 4e51c98

Browse files
committed
Move some unreadable_literal ui tests to correct file
The moved tests were part of `tests/ui/literals.rs` before. Now they are placed in `tests/ui/unreadable_literal.rs`, which now also runs `rustfix` on these 4 extra let statements.
1 parent 92612c9 commit 4e51c98

File tree

5 files changed

+52
-48
lines changed

5 files changed

+52
-48
lines changed

tests/ui/literals.rs

-4
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ fn main() {
3737
let ok16 = 0xFE_BAFE_ABAB_ABCD;
3838
let ok17 = 0x123_4567_8901_usize;
3939

40-
let fail9 = 0xabcdef;
41-
let fail10 = 0xBAFEBAFE;
42-
let fail11 = 0xabcdeff;
43-
let fail12 = 0xabcabcabcabcabcabc;
4440
let fail13 = 0x1_23456_78901_usize;
4541

4642
let fail14 = 2_32;

tests/ui/literals.stderr

+17-43
Original file line numberDiff line numberDiff line change
@@ -86,133 +86,107 @@ help: if you mean to use an octal constant, use `0o`
8686
LL | let fail8 = 0o123;
8787
| ^^^^^
8888

89-
error: long literal lacking separators
90-
--> $DIR/literals.rs:40:17
91-
|
92-
LL | let fail9 = 0xabcdef;
93-
| ^^^^^^^^ help: consider: `0x00ab_cdef`
94-
|
95-
= note: `-D clippy::unreadable-literal` implied by `-D warnings`
96-
97-
error: long literal lacking separators
98-
--> $DIR/literals.rs:41:18
99-
|
100-
LL | let fail10 = 0xBAFEBAFE;
101-
| ^^^^^^^^^^ help: consider: `0xBAFE_BAFE`
102-
103-
error: long literal lacking separators
104-
--> $DIR/literals.rs:42:18
105-
|
106-
LL | let fail11 = 0xabcdeff;
107-
| ^^^^^^^^^ help: consider: `0x0abc_deff`
108-
109-
error: long literal lacking separators
110-
--> $DIR/literals.rs:43:18
111-
|
112-
LL | let fail12 = 0xabcabcabcabcabcabc;
113-
| ^^^^^^^^^^^^^^^^^^^^ help: consider: `0x00ab_cabc_abca_bcab_cabc`
114-
11589
error: digit groups should be smaller
116-
--> $DIR/literals.rs:44:18
90+
--> $DIR/literals.rs:40:18
11791
|
11892
LL | let fail13 = 0x1_23456_78901_usize;
11993
| ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0123_4567_8901_usize`
12094
|
12195
= note: `-D clippy::large-digit-groups` implied by `-D warnings`
12296

12397
error: mistyped literal suffix
124-
--> $DIR/literals.rs:46:18
98+
--> $DIR/literals.rs:42:18
12599
|
126100
LL | let fail14 = 2_32;
127101
| ^^^^ help: did you mean to write: `2_i32`
128102
|
129103
= note: #[deny(clippy::mistyped_literal_suffixes)] on by default
130104

131105
error: mistyped literal suffix
132-
--> $DIR/literals.rs:47:18
106+
--> $DIR/literals.rs:43:18
133107
|
134108
LL | let fail15 = 4_64;
135109
| ^^^^ help: did you mean to write: `4_i64`
136110

137111
error: mistyped literal suffix
138-
--> $DIR/literals.rs:48:18
112+
--> $DIR/literals.rs:44:18
139113
|
140114
LL | let fail16 = 7_8;
141115
| ^^^ help: did you mean to write: `7_i8`
142116

143117
error: mistyped literal suffix
144-
--> $DIR/literals.rs:49:18
118+
--> $DIR/literals.rs:45:18
145119
|
146120
LL | let fail17 = 23_16;
147121
| ^^^^^ help: did you mean to write: `23_i16`
148122

149123
error: digits grouped inconsistently by underscores
150-
--> $DIR/literals.rs:51:18
124+
--> $DIR/literals.rs:47:18
151125
|
152126
LL | let fail19 = 12_3456_21;
153127
| ^^^^^^^^^^ help: consider: `12_345_621`
154128
|
155129
= note: `-D clippy::inconsistent-digit-grouping` implied by `-D warnings`
156130

157131
error: mistyped literal suffix
158-
--> $DIR/literals.rs:52:18
132+
--> $DIR/literals.rs:48:18
159133
|
160134
LL | let fail20 = 2__8;
161135
| ^^^^ help: did you mean to write: `2_i8`
162136

163137
error: mistyped literal suffix
164-
--> $DIR/literals.rs:53:18
138+
--> $DIR/literals.rs:49:18
165139
|
166140
LL | let fail21 = 4___16;
167141
| ^^^^^^ help: did you mean to write: `4_i16`
168142

169143
error: digits grouped inconsistently by underscores
170-
--> $DIR/literals.rs:54:18
144+
--> $DIR/literals.rs:50:18
171145
|
172146
LL | let fail22 = 3__4___23;
173147
| ^^^^^^^^^ help: consider: `3_423`
174148

175149
error: digits grouped inconsistently by underscores
176-
--> $DIR/literals.rs:55:18
150+
--> $DIR/literals.rs:51:18
177151
|
178152
LL | let fail23 = 3__16___23;
179153
| ^^^^^^^^^^ help: consider: `31_623`
180154

181155
error: mistyped literal suffix
182-
--> $DIR/literals.rs:57:18
156+
--> $DIR/literals.rs:53:18
183157
|
184158
LL | let fail24 = 12.34_64;
185159
| ^^^^^^^^ help: did you mean to write: `12.34_f64`
186160

187161
error: mistyped literal suffix
188-
--> $DIR/literals.rs:58:18
162+
--> $DIR/literals.rs:54:18
189163
|
190164
LL | let fail25 = 1E2_32;
191165
| ^^^^^^ help: did you mean to write: `1E2_f32`
192166

193167
error: mistyped literal suffix
194-
--> $DIR/literals.rs:59:18
168+
--> $DIR/literals.rs:55:18
195169
|
196170
LL | let fail26 = 43E7_64;
197171
| ^^^^^^^ help: did you mean to write: `43E7_f64`
198172

199173
error: mistyped literal suffix
200-
--> $DIR/literals.rs:60:18
174+
--> $DIR/literals.rs:56:18
201175
|
202176
LL | let fail27 = 243E17_32;
203177
| ^^^^^^^^^ help: did you mean to write: `243E17_f32`
204178

205179
error: mistyped literal suffix
206-
--> $DIR/literals.rs:61:18
180+
--> $DIR/literals.rs:57:18
207181
|
208182
LL | let fail28 = 241251235E723_64;
209183
| ^^^^^^^^^^^^^^^^ help: did you mean to write: `241_251_235E723_f64`
210184

211185
error: mistyped literal suffix
212-
--> $DIR/literals.rs:62:18
186+
--> $DIR/literals.rs:58:18
213187
|
214188
LL | let fail29 = 42279.911_32;
215189
| ^^^^^^^^^^^^ help: did you mean to write: `42_279.911_f32`
216190

217-
error: aborting due to 31 previous errors
191+
error: aborting due to 27 previous errors
218192

tests/ui/unreadable_literal.fixed

+5
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,9 @@ fn main() {
1717
let bad = (0b11_0110_i64, 0x0123_4567_8901_usize, 123_456_f32, 1.234_567_f32);
1818
let good_sci = 1.1234e1;
1919
let bad_sci = 1.123_456e1;
20+
21+
let fail9 = 0x00ab_cdef;
22+
let fail10: u32 = 0xBAFE_BAFE;
23+
let fail11 = 0x0abc_deff;
24+
let fail12: i128 = 0x00ab_cabc_abca_bcab_cabc;
2025
}

tests/ui/unreadable_literal.rs

+5
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,9 @@ fn main() {
1717
let bad = (0b110110_i64, 0x12345678901_usize, 123456_f32, 1.234567_f32);
1818
let good_sci = 1.1234e1;
1919
let bad_sci = 1.123456e1;
20+
21+
let fail9 = 0xabcdef;
22+
let fail10: u32 = 0xBAFEBAFE;
23+
let fail11 = 0xabcdeff;
24+
let fail12: i128 = 0xabcabcabcabcabcabc;
2025
}

tests/ui/unreadable_literal.stderr

+25-1
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,29 @@ error: long literal lacking separators
3030
LL | let bad_sci = 1.123456e1;
3131
| ^^^^^^^^^^ help: consider: `1.123_456e1`
3232

33-
error: aborting due to 5 previous errors
33+
error: long literal lacking separators
34+
--> $DIR/unreadable_literal.rs:21:17
35+
|
36+
LL | let fail9 = 0xabcdef;
37+
| ^^^^^^^^ help: consider: `0x00ab_cdef`
38+
39+
error: long literal lacking separators
40+
--> $DIR/unreadable_literal.rs:22:23
41+
|
42+
LL | let fail10: u32 = 0xBAFEBAFE;
43+
| ^^^^^^^^^^ help: consider: `0xBAFE_BAFE`
44+
45+
error: long literal lacking separators
46+
--> $DIR/unreadable_literal.rs:23:18
47+
|
48+
LL | let fail11 = 0xabcdeff;
49+
| ^^^^^^^^^ help: consider: `0x0abc_deff`
50+
51+
error: long literal lacking separators
52+
--> $DIR/unreadable_literal.rs:24:24
53+
|
54+
LL | let fail12: i128 = 0xabcabcabcabcabcabc;
55+
| ^^^^^^^^^^^^^^^^^^^^ help: consider: `0x00ab_cabc_abca_bcab_cabc`
56+
57+
error: aborting due to 9 previous errors
3458

0 commit comments

Comments
 (0)