Skip to content

Go-to-definition on a trait function should go to the implementation, not the declaration #6567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyn514 opened this issue Nov 17, 2020 · 2 comments

Comments

@jyn514
Copy link
Member

jyn514 commented Nov 17, 2020

I ran across this in rustdoc, but I'm sure it's easy to reproduce in small codebases.

Pressing F12 on clean in https://github.com/rust-lang/rust/blob/9b2b02a840f358bcadef5c3ae861d2852da20b3d/src/librustdoc/clean/mod.rs#L1110 goes to https://github.com/rust-lang/rust/blob/9b2b02a840f358bcadef5c3ae861d2852da20b3d/src/librustdoc/clean/mod.rs#L54. It should instead go to https://github.com/rust-lang/rust/blob/9b2b02a840f358bcadef5c3ae861d2852da20b3d/src/librustdoc/clean/mod.rs#L889.

@jyn514
Copy link
Member Author

jyn514 commented Nov 17, 2020

Github should really show the code preview across git repositories :/

@flodiebold
Copy link
Member

Duplicate of #4558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants