Skip to content

Format string syntax #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnicola opened this issue Mar 3, 2020 · 6 comments
Closed

Format string syntax #3419

lnicola opened this issue Mar 3, 2020 · 6 comments
Labels
A-diagnostics diagnostics / error reporting E-medium fun A technically challenging issue with high impact S-actionable Someone could pick this issue up and work on it right now

Comments

@lnicola
Copy link
Member

lnicola commented Mar 3, 2020

If IntelliJ can do it, so can we.

@lnicola lnicola added the fun A technically challenging issue with high impact label Mar 3, 2020
@bjorn3
Copy link
Member

bjorn3 commented Dec 20, 2020

Syntax highlighting is implemented, but syntax errors in format strings aren't shown.

@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 22, 2021
@DJMcNab
Copy link
Contributor

DJMcNab commented Apr 6, 2021

Another thought would be to link to the specific Display/Debug implementation when go to definition is activated on {}/{:?} (using the same infrastructure from #4558)

@Milo123459
Copy link
Contributor

I'm going to have a look into implementing this (hopefully!).

@Veykril
Copy link
Member

Veykril commented Sep 21, 2021

Go ahead, feel free to reach out here/on zulip if you have any questions or need directions(also see https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/syntax_highlighting/format.rs for how highlighting deals with this already)

@Veykril Veykril added A-highlighting (semantic) token highlighting and removed A-highlighting (semantic) token highlighting labels Dec 4, 2021
@Veykril Veykril added the A-diagnostics diagnostics / error reporting label Dec 20, 2021
@Veykril Veykril assigned Veykril and unassigned Veykril Jan 14, 2022
@ChayimFriedman2
Copy link
Contributor

Granted, format strings need special handling in many IDE features and break once a while, but is there still something to specifically track in this issue?

@lnicola
Copy link
Member Author

lnicola commented Oct 27, 2024

I guess not. I'd love an assist to replace path expressions, though.

@lnicola lnicola closed this as completed Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics diagnostics / error reporting E-medium fun A technically challenging issue with high impact S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

7 participants