Skip to content

There are some leftovers of the no-longer-existing "platform-intrinsic" ABI in RA #18491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RalfJung opened this issue Nov 7, 2024 · 4 comments · Fixed by #18595
Closed

There are some leftovers of the no-longer-existing "platform-intrinsic" ABI in RA #18491

RalfJung opened this issue Nov 7, 2024 · 4 comments · Fixed by #18595
Labels
C-cleanup Category: issues documenting cleanup E-easy

Comments

@RalfJung
Copy link
Member

RalfJung commented Nov 7, 2024

Grepping for PlatformIntrinsic and platform-intrinsic shows some results; this can all be removed -- that ABI does not exist any more.
@flodiebold flodiebold added the C-cleanup Category: issues documenting cleanup label Nov 28, 2024
@Veykril
Copy link
Member

Veykril commented Dec 2, 2024

When were the last mentions in the standard libraries of these removed? We need to carry the support code for them for a bit longer I imagine.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 2, 2024

Looks like that was in rust-lang/stdarch@56087ea, which probably propagated to the rustc repo shortly thereafter.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 2, 2024

The Rust compiler itself removed support for them in rust-lang/rust#121516, so at that point (Feb 27th, 2024) they were definitely gone from the standard library.

@Veykril
Copy link
Member

Veykril commented Dec 2, 2024

Okay then its safe for us to remove

@Veykril Veykril added the E-easy label Dec 2, 2024
@markmurphydev markmurphydev mentioned this issue Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: issues documenting cleanup E-easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to platform-intrinsic ABI markmurphydev/rust-analyzer
3 participants
@RalfJung @flodiebold @Veykril