Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check.workspace option no longer implies cargo check will always use --workspace flag #18104

Open
soooch opened this issue Sep 12, 2024 · 1 comment
Labels
Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug

Comments

@soooch
Copy link

soooch commented Sep 12, 2024

This breaks configs with extra_args which assume --workspace will be in the check command when check.workspace is true. In my case, this means I can not use --exclude arguments in "extra_args" without flycheck failing.

this behavior was changed here: https://github.com/rust-lang/rust-analyzer/pull/17912/files#diff-532b0325efe572c4000020f9997a934629c3798d7a69ede6520f519417638d9aR376

A potential fix may be the addition of a new "workspace_extra_args" config option.

@alibektas @Veykril @mo8it

rust-analyzer version: 0.3.2104-standalone

rustc version: 1.78

editor or extension: VSCode

relevant settings:

{
    "rust-analyzer.cargo.extraArgs": [
        "--exclude",
        "some_crate",
    ],
    "rust-analyzer.check.workspace": true,
}
@soooch soooch added the C-bug Category: bug label Sep 12, 2024
@soooch soooch changed the title check_workspace option no longer implies cargo check will always use --workspace flag which breaks extra_args which assumes --workspace flag check_workspace option no longer implies cargo check will always use --workspace flag which breaks extra_args which assume --workspace flag Sep 12, 2024
@soooch soooch changed the title check_workspace option no longer implies cargo check will always use --workspace flag which breaks extra_args which assume --workspace flag check_workspace option no longer implies cargo check will always use --workspace flag which breaks extra_args which assume --workspace flag Sep 12, 2024
@soooch soooch changed the title check_workspace option no longer implies cargo check will always use --workspace flag which breaks extra_args which assume --workspace flag check_workspace option no longer implies cargo check will always use --workspace flag Sep 12, 2024
@soooch soooch changed the title check_workspace option no longer implies cargo check will always use --workspace flag check.workspace option no longer implies cargo check will always use --workspace flag Sep 12, 2024
@soooch
Copy link
Author

soooch commented Sep 12, 2024

I can PR my suggested fix if it sounds like a reasonable solution.

@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants