Skip to content

Don't use --workspace for build scripts #17696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
themighty1 opened this issue Jul 25, 2024 · 4 comments
Closed

Don't use --workspace for build scripts #17696

themighty1 opened this issue Jul 25, 2024 · 4 comments
Labels
C-feature Category: feature request

Comments

@themighty1
Copy link

Please provide a config similar to rust-analyzer.check.workspace but for build scripts.
I need to be able to run only the build script of the current package and not the build scripts of the workspace deps.

In my specific case, I have a workspace member A which is supposed to be compiled for "wasm32-unknown-unknown", whereas the rest of the workspace should be compiled to the native arch.

I'm already using "rust-analyzer.check.workspace": false but I still get errors from workspace build scripts.

@themighty1 themighty1 added the C-feature Category: feature request label Jul 25, 2024
@themighty1
Copy link
Author

Seems like this PR was meant to do just what I asked #16510

But I empirically established that --workspace still gets passed to build scripts even with "rust-analyzer.check.workspace": false

@themighty1
Copy link
Author

using rust=analyzer 0.3.2037-standalone from vscode 1.91.1

@Veykril
Copy link
Member

Veykril commented Jul 25, 2024

The config there serves a different purpose, mainly that of checking speed. Omitting the --workspace flag in buildscript wouldn't make sense, as then we will simply not run build-scripts and not build proc-macros for the project making r-a pretty much useless.

@themighty1
Copy link
Author

ok, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature request
Projects
None yet
Development

No branches or pull requests

2 participants