Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove box_syntax #14504

Closed
lowr opened this issue Apr 6, 2023 · 0 comments · Fixed by #15557
Closed

Remove box_syntax #14504

lowr opened this issue Apr 6, 2023 · 0 comments · Fixed by #15557
Labels
A-parser parser issues A-ty type system / type inference / traits / method resolution C-cleanup Category: issues documenting cleanup S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.

Comments

@lowr
Copy link
Contributor

lowr commented Apr 6, 2023

rust-lang/rust#108471 removed box_syntax (don't be confused with box_patterns, which is a distinct feature and unaffected). rustc now emits a temporary lint to replace them with Box::new() to facilitate the migration. We should follow the removal, but I think it's best to do so only after the migration seems to be mostly done and the lint is removed.

Filing this issue so we won't forget and so we can also discuss when to remove if anyone has opinion.
@lowr lowr added A-ty type system / type inference / traits / method resolution A-parser parser issues S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. C-cleanup Category: issues documenting cleanup labels Apr 6, 2023
@lowr lowr mentioned this issue Apr 28, 2023
Merged
@Veykril Veykril mentioned this issue Sep 5, 2023
Merged
@bors bors closed this as completed in caeea45 Sep 5, 2023
phanen added a commit to phanen/rvasm that referenced this issue Oct 25, 2023
@phanen
Fix removal of box_syntax
625e76c 
see rust-lang/rust-analyzer#14504
@phanen phanen mentioned this issue Oct 25, 2023
Merged
eigenraven pushed a commit to eigenraven/rvasm that referenced this issue Oct 26, 2023
@phanen
Fix removal of box_syntax (#1)
b38f1a6 
see rust-lang/rust-analyzer#14504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser parser issues A-ty type system / type inference / traits / method resolution C-cleanup Category: issues documenting cleanup S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
1 participant
@lowr