Skip to content

Goto definition of implementation of trait is not accurate. #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wasd96040501 opened this issue Sep 5, 2021 · 1 comment
Closed

Goto definition of implementation of trait is not accurate. #10153

wasd96040501 opened this issue Sep 5, 2021 · 1 comment

Comments

@wasd96040501
Copy link
Contributor

https://github.com/rust-analyzer/rust-analyzer/blob/c16e6474f9e4d11d967e5309735b0e673f4c24da/crates/ide/src/goto_definition.rs#L176-L178
When I run goto definition of .try_to_nav, it navigate to
https://github.com/rust-analyzer/rust-analyzer/blob/c16e6474f9e4d11d967e5309735b0e673f4c24da/crates/ide/src/display/navigation_target.rs#L74-L76
which seems not accurate. Because def is in clear definition Definition. So It should navigate to implementation of .try_to_nav
https://github.com/rust-analyzer/rust-analyzer/blob/c16e6474f9e4d11d967e5309735b0e673f4c24da/crates/ide/src/display/navigation_target.rs#L202-L204
@flodiebold
Copy link
Member

Duplicate of #4558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flodiebold @wasd96040501