Skip to content

Commit

Permalink
vscode: Fix line and col regexp for problem matcher
Browse files Browse the repository at this point in the history
When building the Rust compiler with `./x check` from within VS Code,
the current `rustc` problem matcher thinks that the output from that
command that looks like this:

    Build completed successfully in 0:00:26

is about a problem in a file named `0` on line 00, col 26. This wouldn't
be so bad if it wasn't for that VS Code tends to get stuck on this
problem because of problems with opening the file '0'.

The rust compiler will never output problems with a line or a column
that starts with 0, so change the regexp to require lines and cols to
begin with [1-9] to fix this problem.
Enselic committed Sep 29, 2023

Verified

This commit was signed with the committer’s verified signature.
VannTen Max Gautier
1 parent 547bcf8 commit dd8ea97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion editors/code/package.json
Original file line number Diff line number Diff line change
@@ -1621,7 +1621,7 @@
"message": 3
},
{
"regexp": "^[\\s->=]*(.*?):(\\d*):(\\d*)\\s*$",
"regexp": "^[\\s->=]*(.*?):([1-9]\\d*):([1-9]\\d*)\\s*$",
"file": 1,
"line": 2,
"column": 3

0 comments on commit dd8ea97

Please sign in to comment.