Skip to content

Commit cca0ceb

Browse files
committed
Use a u64 for the rmeta root position
1 parent e550422 commit cca0ceb

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

crates/proc-macro-api/src/version.rs

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,18 @@ pub fn read_version(dylib_path: &AbsPath) -> io::Result<String> {
120120
let version = u32::from_be_bytes([dot_rustc[4], dot_rustc[5], dot_rustc[6], dot_rustc[7]]);
121121
// Last supported version is:
122122
// https://github.com/rust-lang/rust/commit/0696e79f2740ad89309269b460579e548a5cd632
123-
let snappy_portion = match version {
124-
5 | 6 => &dot_rustc[8..],
123+
let (snappy_portion, bytes_before_version) = match version {
124+
5 | 6 => (&dot_rustc[8..], 13),
125125
7 | 8 => {
126126
let len_bytes = &dot_rustc[8..12];
127127
let data_len = u32::from_be_bytes(len_bytes.try_into().unwrap()) as usize;
128-
&dot_rustc[12..data_len + 12]
128+
(&dot_rustc[12..data_len + 12], 13)
129129
}
130+
9 => {
131+
let len_bytes = &dot_rustc[8..16];
132+
let data_len = u64::from_le_bytes(len_bytes.try_into().unwrap()) as usize;
133+
(&dot_rustc[16..data_len + 12], 17)
134+
}
130135
_ => {
131136
return Err(io::Error::new(
132137
io::ErrorKind::InvalidData,
@@ -142,15 +147,15 @@ pub fn read_version(dylib_path: &AbsPath) -> io::Result<String> {
142147
Box::new(SnapDecoder::new(snappy_portion))
143148
};
144149

145-
// the bytes before version string bytes, so this basically is:
150+
// We're going to skip over the bytes before the version string, so basically:
146151
// 8 bytes for [b'r',b'u',b's',b't',0,0,0,5]
147-
// 4 bytes for [crate root bytes]
152+
// 4 or 8 bytes for [crate root bytes]
148153
// 1 byte for length of version string
149-
// so 13 bytes in total, and we should check the 13th byte
154+
// so 13 or 17 bytes in total, and we should check the last of those bytes
150155
// to know the length
151-
let mut bytes_before_version = [0u8; 13];
156+
let mut bytes_before_version = vec![0u8; bytes_before_version];
152157
uncompressed.read_exact(&mut bytes_before_version)?;
153-
let length = bytes_before_version[12];
158+
let length = *bytes_before_version.last().unwrap();
154159

155160
let mut version_string_utf8 = vec![0u8; length as usize];
156161
uncompressed.read_exact(&mut version_string_utf8)?;

0 commit comments

Comments
 (0)