Skip to content

Commit ba6f0be

Browse files
committed
Simplify remove_parentheses's implementation
1 parent 8d42439 commit ba6f0be

File tree

1 file changed

+6
-21
lines changed

1 file changed

+6
-21
lines changed

crates/ide-assists/src/handlers/remove_parentheses.rs

+6-21
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use syntax::{ast, AstNode, SyntaxKind, TextRange};
1+
use syntax::{ast, AstNode};
22

33
use crate::{AssistContext, AssistId, AssistKind, Assists};
44

@@ -19,43 +19,28 @@ use crate::{AssistContext, AssistId, AssistKind, Assists};
1919
// ```
2020
pub(crate) fn remove_parentheses(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
2121
let parens = ctx.find_node_at_offset::<ast::ParenExpr>()?;
22-
let l_paren = parens.l_paren_token()?;
23-
let r_paren = parens.r_paren_token()?;
2422

25-
let cursor_in_range = l_paren.text_range().contains_range(ctx.selection_trimmed())
26-
|| r_paren.text_range().contains_range(ctx.selection_trimmed());
23+
let cursor_in_range =
24+
parens.l_paren_token()?.text_range().contains_range(ctx.selection_trimmed())
25+
|| parens.r_paren_token()?.text_range().contains_range(ctx.selection_trimmed());
2726
if !cursor_in_range {
2827
return None;
2928
}
3029

3130
let expr = parens.expr()?;
31+
3232
let parent = ast::Expr::cast(parens.syntax().parent()?);
3333
let is_ok_to_remove = expr.precedence() >= parent.as_ref().and_then(ast::Expr::precedence);
3434
if !is_ok_to_remove {
3535
return None;
3636
}
3737

38-
let delete_from_l = l_paren.text_range().start();
39-
let delete_to_l = match l_paren.next_token() {
40-
Some(it) if it.kind() == SyntaxKind::WHITESPACE => it.text_range().end(),
41-
_ => l_paren.text_range().end(),
42-
};
43-
44-
let delete_from_r = match r_paren.prev_token() {
45-
Some(it) if it.kind() == SyntaxKind::WHITESPACE => it.text_range().start(),
46-
_ => r_paren.text_range().start(),
47-
};
48-
let delete_to_r = r_paren.text_range().end();
49-
5038
let target = parens.syntax().text_range();
5139
acc.add(
5240
AssistId("remove_parentheses", AssistKind::Refactor),
5341
"Remove redundant parentheses",
5442
target,
55-
|builder| {
56-
builder.delete(TextRange::new(delete_from_l, delete_to_l));
57-
builder.delete(TextRange::new(delete_from_r, delete_to_r));
58-
},
43+
|builder| builder.replace_ast(parens.into(), expr),
5944
)
6045
}
6146

0 commit comments

Comments
 (0)