Skip to content

Commit 9d26984

Browse files
committed
Add terminate process implemntation note
1 parent 06053a0 commit 9d26984

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

editors/code/src/utils/processes.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ import { join } from 'path';
88
const isWindows = process.platform === 'win32';
99
const isMacintosh = process.platform === 'darwin';
1010
const isLinux = process.platform === 'linux';
11+
12+
// this is very complex, but is basically copy-pased from VSCode implementation here:
13+
// https://github.com/Microsoft/vscode-languageserver-node/blob/dbfd37e35953ad0ee14c4eeced8cfbc41697b47e/client/src/utils/processes.ts#L15
14+
15+
// And see discussion at
16+
// https://github.com/rust-analyzer/rust-analyzer/pull/1079#issuecomment-478908109
17+
1118
export function terminate(process: ChildProcess, cwd?: string): boolean {
1219
if (isWindows) {
1320
try {

0 commit comments

Comments
 (0)