Skip to content

Commit

Permalink
Auto merge of #18011 - Wilfred:op_queue_doc_comments, r=Veykril
Browse files Browse the repository at this point in the history
internal: Add doc comments to OpQueue

I spent a while debugging some OpQueue behaviours and found the API slightly confusing, so I've added doc comments to clarify what each OpQueue method does.
  • Loading branch information
bors committed Aug 31, 2024
2 parents 30c14ca + 730e7fb commit 1a84cd6
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions crates/rust-analyzer/src/op_queue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,28 +37,39 @@ impl<Args, Output: Default> Default for OpQueue<Args, Output> {
}

impl<Args, Output> OpQueue<Args, Output> {
/// Request an operation to start.
pub(crate) fn request_op(&mut self, reason: Cause, args: Args) {
self.op_requested = Some((reason, args));
}

/// If there was an operation requested, mark this queue as
/// started and return the request arguments.
pub(crate) fn should_start_op(&mut self) -> Option<(Cause, Args)> {
if self.op_in_progress {
return None;
}
self.op_in_progress = self.op_requested.is_some();
self.op_requested.take()
}

/// Mark an operation as completed.
pub(crate) fn op_completed(&mut self, result: Output) {
assert!(self.op_in_progress);
self.op_in_progress = false;
self.last_op_result = result;
}

/// Get the result of the last operation.
pub(crate) fn last_op_result(&self) -> &Output {
&self.last_op_result
}

// Is there an operation that has started, but hasn't yet finished?
pub(crate) fn op_in_progress(&self) -> bool {
self.op_in_progress
}

// Has an operation been requested?
pub(crate) fn op_requested(&self) -> bool {
self.op_requested.is_some()
}
Expand Down

0 comments on commit 1a84cd6

Please sign in to comment.