Auto merge of #1416 - Xanewok:allow-unstable-in-dev, r=Xanewok

Allow unstable features under "dev" channel

This brings it in line with what's used by Rust and Rustfmt.

Closes #1414.

r? @jsgf

@bors delegate=jsgf (hopefully this works)

Author: bors

rls/src/config.rs

@@ -103,6 +103,18 @@ impl<T> AsRef<T> for Inferrable<T> {
     }
 }
 
+/// Returns whether unstable features are allowed.
+///
+/// It is very similar to what rustfmt uses [[1]] - it relies on
+/// CFG_RELEASE_CHANNEL being set by Rust bootstrap.
+/// In case the env var is missing, we assume that we're built by Cargo and are
+/// using nightly since that's the only channel supported right now.
+///
+/// [1]: https://github.com/rust-lang/rustfmt/blob/dfa94d150555da40780413d7f1a1378565208c99/src/config/config_type.rs#L53-L67
+pub fn unstable_features_allowed() -> bool {
+    option_env!("CFG_RELEASE_CHANNEL").map_or(true, |c| c == "nightly" || c == "dev")
+}
+
 /// RLS configuration options.
 #[derive(Clone, Debug, Deserialize)]
 #[allow(missing_docs)]
@@ -251,10 +263,7 @@ impl Config {
     /// Ensures that unstable options are only allowed if `unstable_features` is
     /// true and that is not allowed on stable release channels.
     pub fn normalise(&mut self) {
-        let allow_unstable =
-            option_env!("CFG_RELEASE_CHANNEL").map(|c| c == "nightly").unwrap_or(true);
-
-        if !allow_unstable {
+        if !unstable_features_allowed() {
             if self.unstable_features {
                 eprintln!("`unstable_features` setting can only be used on nightly channel");
             }