Skip to content

Commit ae859c3

Browse files
committed
add comment mentioning alternative approach
1 parent db067f4 commit ae859c3

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

cargo-miri/bin.rs

+5
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,11 @@ fn phase_cargo_miri(mut args: env::Args) {
397397
setup(subcommand);
398398

399399
// Invoke actual cargo for the job, but with different flags.
400+
// We re-use `cargo test` and `cargo run`, which makes target and binary handling very easy but
401+
// requires some extra work to make the build check-only (see all the `--emit` hacks below).
402+
// <https://github.com/rust-lang/miri/pull/1540#issuecomment-693553191> describes an alternative
403+
// approach that uses `cargo check`, making that part easier but target and binary handling
404+
// harder.
400405
let miri_path = std::env::current_exe().expect("current executable path invalid");
401406
let cargo_cmd = match subcommand {
402407
MiriCommand::Test => "test",

0 commit comments

Comments
 (0)