musl: HWCAP_* consts missing on aarch64 targets #2171
Labels
C-API-request
Category: API request
Comments
This was referenced May 12, 2021
tarcieri
added a commit
to RustCrypto/utils
that referenced
this issue
May 13, 2021
The `libc` crate doesn't presently define Linux's `HWCAP_*` in Musl-based environments: rust-lang/libc#2171 This PR (temporarily) copies the presently supported `HWCAP_*` constants directly into this crate. Additionally, it adds support for the `neon` target feature.
tarcieri
added a commit
to RustCrypto/utils
that referenced
this issue
May 13, 2021
The `libc` crate doesn't presently define Linux's `HWCAP_*` in Musl-based environments: rust-lang/libc#2171 This PR (temporarily) copies the presently supported `HWCAP_*` constants directly into this crate. Additionally, it adds support for the `neon` target feature.
bors
added a commit
that referenced
this issue
May 13, 2021
musl: add missing AArch64 HWCAP_* consts Closes #2171. I effectively just copied and pasted these from #1638 after confirming that they are identical to musl's [aarch64/bits/hwcap.h](https://github.com/bminor/musl/blob/4433115/arch/aarch64/bits/hwcap.h) and that musl's `getauxval()` also takes a `c_ulong`. It seems like if these are added it would address some of [`TODO-linux.txt`](https://github.com/rust-lang/libc/blob/ed1399a/libc-test/semver/TODO-linux.txt)?
bors
added a commit
that referenced
this issue
May 14, 2021
musl: add missing AArch64 HWCAP_* consts Closes #2171. I effectively just copied and pasted these from #1638 after confirming that they are identical to musl's [aarch64/bits/hwcap.h](https://github.com/bminor/musl/blob/4433115/arch/aarch64/bits/hwcap.h) and that musl's `getauxval()` also takes a `c_ulong`. It seems like if these are added it would address some of [`TODO-linux.txt`](https://github.com/rust-lang/libc/blob/ed1399a/libc-test/semver/TODO-linux.txt)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
It looks like #1638 added these constants, but for glibc only. #2109 added a
TODO-linux.txtwhich made a note of this.I just received an in-the-wild report about this (RustCrypto/hashes#273) and noticed there wasn't a specific tracking issue for it, so I thought I'd open one.
At first glance it seems like this could be resolved by a PR similar to #1638, but adding the constants to
linux/musl/b64/aarch64/mod.rs.Is that the case? If so, I could try to open a PR to add these constants. Edit: opened #2172.
The text was updated successfully, but these errors were encountered: