Skip to content

Commit fb2b3da

Browse files
committed
Auto merge of #1224 - gnzlbg:fix_android, r=gnzlbg
Re-enable android build jobs This performs a `yes | ./sdk/tools/bin/sdkmanager --licenses` - the sole purpose of the `--licenses` flag is to allow the user to accept all licenses a priori, so that all other commands don't show any licenses. For some reason, after all licenses have been accepted, the install step says that some licenses are still not accepted... so we need to accept those too... Why? I have no idea, and accepting licenses while installing still appears to make things hang a little, but it only does so for one non-accepted license, instead of for 5-6 like before, so now things do work.
2 parents 70284d7 + 4f9cc1a commit fb2b3da

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.travis.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,9 @@ matrix:
8989
- shellcheck ci/*.sh
9090

9191
allow_failures:
92-
- env: TARGET=aarch64-linux-android
93-
- env: TARGET=x86_64-linux-android
92+
# FIXME: https://github.com/rust-lang/libc/issues/1226
93+
- env: TARGET=asmjs-unknown-emscripten
94+
- env: TARGET=wasm32-unknown-emscripten
9495

9596
install: rustup target add $TARGET
9697
script:

ci/android-install-sdk.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ case "$1" in
4646
esac;
4747

4848
# --no_https avoids
49-
# javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: No trusted certificate found
50-
echo "yes" | \
51-
./sdk/tools/bin/sdkmanager --no_https \
49+
# javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: No trusted certificate found
50+
yes | ./sdk/tools/bin/sdkmanager --licenses --no_https
51+
yes | ./sdk/tools/bin/sdkmanager --no_https \
5252
"emulator" \
5353
"platform-tools" \
5454
"platforms;android-24" \

libc-test/build.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ fn main() {
658658
// MFD_HUGETLB is not available in some older libc versions on the CI builders. On the
659659
// x86_64 and i686 builders it seems to be available for all targets, so at least test
660660
// it there.
661-
"MFD_HUGETLB" if !(x86_64 || i686) || musl => true,
661+
"MFD_HUGETLB" if !(x86_64 || i686) || musl || (x86_64 && android)=> true,
662662

663663
"DT_FIFO" | "DT_CHR" | "DT_DIR" | "DT_BLK" | "DT_REG"
664664
| "DT_LNK" | "DT_SOCK"

0 commit comments

Comments
 (0)