Skip to content

Commit

Permalink
chore: add labels to FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
lvllvl committed Jan 7, 2025
1 parent 4bc5300 commit 2c456ae
Show file tree
Hide file tree
Showing 10 changed files with 52 additions and 52 deletions.
6 changes: 3 additions & 3 deletions src/unix/hurd/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ pub type nl_item = c_int;
pub type iconv_t = *mut c_void;

#[cfg_attr(feature = "extra_traits", derive(Debug))]
pub enum fpos64_t {} // FIXME: fill this out with a struct
pub enum fpos64_t {} // FIXME(hurd): fill this out with a struct
impl Copy for fpos64_t {}
impl Clone for fpos64_t {
fn clone(&self) -> fpos64_t {
Expand Down Expand Up @@ -814,7 +814,7 @@ s! {
pub ifa_flags: c_uint,
pub ifa_addr: *mut crate::sockaddr,
pub ifa_netmask: *mut crate::sockaddr,
pub ifa_ifu: *mut crate::sockaddr, // FIXME This should be a union
pub ifa_ifu: *mut crate::sockaddr, // FIXME(union) This should be a union
pub ifa_data: *mut c_void,
}

Expand Down Expand Up @@ -1092,7 +1092,7 @@ cfg_if! {
.field("ut_line", &self.ut_line)
.field("ut_id", &self.ut_id)
.field("ut_user", &self.ut_user)
// FIXME: .field("ut_host", &self.ut_host)
// FIXME(hurd): .field("ut_host", &self.ut_host)
.field("ut_exit", &self.ut_exit)
.field("ut_session", &self.ut_session)
.field("ut_tv", &self.ut_tv)
Expand Down
6 changes: 3 additions & 3 deletions src/unix/linux_like/android/b32/x86/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,11 @@ pub const SYS_personality: c_long = 136;
pub const SYS_afs_syscall: c_long = 137;
pub const SYS_setfsuid: c_long = 138;
pub const SYS_setfsgid: c_long = 139;
// FIXME: SYS__llseek is in the NDK sources but for some reason is
// FIXME(linux): SYS__llseek is in the NDK sources but for some reason is
// not available in the tests
// pub const SYS__llseek: c_long = 140;
pub const SYS_getdents: c_long = 141;
// FIXME: SYS__newselect is in the NDK sources but for some reason is
// FIXME(linux): SYS__newselect is in the NDK sources but for some reason is
// not available in the tests
// pub const SYS__newselect: c_long = 142;
pub const SYS_flock: c_long = 143;
Expand All @@ -294,7 +294,7 @@ pub const SYS_readv: c_long = 145;
pub const SYS_writev: c_long = 146;
pub const SYS_getsid: c_long = 147;
pub const SYS_fdatasync: c_long = 148;
// FIXME: SYS__llseek is in the NDK sources but for some reason is
// FIXME(linux): SYS__llseek is in the NDK sources but for some reason is
// not available in the tests
// pub const SYS__sysctl: c_long = 149;
pub const SYS_mlock: c_long = 150;
Expand Down
6 changes: 3 additions & 3 deletions src/unix/linux_like/android/b64/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_mutex_t")
.field("value", &self.value)
// FIXME: .field("__reserved", &self.__reserved)
// FIXME(emscripten): .field("__reserved", &self.__reserved)
.finish()
}
}
Expand Down Expand Up @@ -190,7 +190,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_cond_t")
.field("value", &self.value)
// FIXME: .field("__reserved", &self.__reserved)
// FIXME(emscripten): .field("__reserved", &self.__reserved)
.finish()
}
}
Expand Down Expand Up @@ -227,7 +227,7 @@ cfg_if! {
.field("pendingReaders", &self.pendingReaders)
.field("pendingWriters", &self.pendingWriters)
.field("attr", &self.attr)
// FIXME: .field("__reserved", &self.__reserved)
// FIXME(emscripten): .field("__reserved", &self.__reserved)
.finish()
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/unix/linux_like/android/b64/x86_64/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ cfg_if! {
.field("mxcsr", &self.mxcsr)
.field("mxcr_mask", &self.mxcr_mask)
.field("st_space", &self.st_space)
// FIXME: .field("xmm_space", &self.xmm_space)
// FIXME(android): .field("xmm_space", &self.xmm_space)
// Ignore padding field
.finish()
}
Expand Down Expand Up @@ -545,7 +545,7 @@ pub const SYS_munlockall: c_long = 152;
pub const SYS_vhangup: c_long = 153;
pub const SYS_modify_ldt: c_long = 154;
pub const SYS_pivot_root: c_long = 155;
// FIXME: SYS__sysctl is in the NDK sources but for some reason is
// FIXME(android): SYS__sysctl is in the NDK sources but for some reason is
// not available in the tests
// pub const SYS__sysctl: c_long = 156;
pub const SYS_prctl: c_long = 157;
Expand Down
8 changes: 4 additions & 4 deletions src/unix/linux_like/android/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ cfg_if! {
.field("d_off", &self.d_off)
.field("d_reclen", &self.d_reclen)
.field("d_type", &self.d_type)
// FIXME: .field("d_name", &self.d_name)
// FIXME(android): .field("d_name", &self.d_name)
.finish()
}
}
Expand Down Expand Up @@ -728,7 +728,7 @@ cfg_if! {
.field("d_off", &self.d_off)
.field("d_reclen", &self.d_reclen)
.field("d_type", &self.d_type)
// FIXME: .field("d_name", &self.d_name)
// FIXME(android): .field("d_name", &self.d_name)
.finish()
}
}
Expand Down Expand Up @@ -800,7 +800,7 @@ cfg_if! {
f.debug_struct("lastlog")
.field("ll_time", &self.ll_time)
.field("ll_line", &self.ll_line)
// FIXME: .field("ll_host", &self.ll_host)
// FIXME(android): .field("ll_host", &self.ll_host)
.finish()
}
}
Expand Down Expand Up @@ -851,7 +851,7 @@ cfg_if! {
.field("ut_line", &self.ut_line)
.field("ut_id", &self.ut_id)
.field("ut_user", &self.ut_user)
// FIXME: .field("ut_host", &self.ut_host)
// FIXME(android): .field("ut_host", &self.ut_host)
.field("ut_exit", &self.ut_exit)
.field("ut_session", &self.ut_session)
.field("ut_tv", &self.ut_tv)
Expand Down
8 changes: 4 additions & 4 deletions src/unix/linux_like/emscripten/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ pub type statvfs64 = crate::statvfs;
pub type dirent64 = crate::dirent;

#[cfg_attr(feature = "extra_traits", derive(Debug))]
pub enum fpos64_t {} // FIXME: fill this out with a struct
pub enum fpos64_t {} // FIXME(emscripten): fill this out with a struct
impl Copy for fpos64_t {}
impl Clone for fpos64_t {
fn clone(&self) -> fpos64_t {
Expand Down Expand Up @@ -412,7 +412,7 @@ cfg_if! {
.field("d_off", &self.d_off)
.field("d_reclen", &self.d_reclen)
.field("d_type", &self.d_type)
// FIXME: .field("d_name", &self.d_name)
// FIXME(emscripten): .field("d_name", &self.d_name)
.finish()
}
}
Expand Down Expand Up @@ -465,7 +465,7 @@ cfg_if! {
.field("totalhigh", &self.totalhigh)
.field("freehigh", &self.freehigh)
.field("mem_unit", &self.mem_unit)
// FIXME: .field("__reserved", &self.__reserved)
// FIXME(emscripten): .field("__reserved", &self.__reserved)
.finish()
}
}
Expand Down Expand Up @@ -525,7 +525,7 @@ cfg_if! {
impl fmt::Debug for pthread_cond_t {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_cond_t")
// FIXME: .field("size", &self.size)
// FIXME(emscripten): .field("size", &self.size)
.finish()
}
}
Expand Down
18 changes: 9 additions & 9 deletions src/unix/linux_like/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ s! {
pub ifa_flags: c_uint,
pub ifa_addr: *mut crate::sockaddr,
pub ifa_netmask: *mut crate::sockaddr,
pub ifa_ifu: *mut crate::sockaddr, // FIXME This should be a union
pub ifa_ifu: *mut crate::sockaddr, // FIXME(union) This should be a union
pub ifa_data: *mut c_void,
}

Expand Down Expand Up @@ -347,7 +347,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("sockaddr_un")
.field("sun_family", &self.sun_family)
// FIXME: .field("sun_path", &self.sun_path)
// FIXME(linux): .field("sun_path", &self.sun_path)
.finish()
}
}
Expand Down Expand Up @@ -376,7 +376,7 @@ cfg_if! {
f.debug_struct("sockaddr_storage")
.field("ss_family", &self.ss_family)
.field("__ss_align", &self.__ss_align)
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
// FIXME(linux): .field("__ss_pad2", &self.__ss_pad2)
.finish()
}
}
Expand Down Expand Up @@ -427,12 +427,12 @@ cfg_if! {
impl fmt::Debug for utsname {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utsname")
// FIXME: .field("sysname", &self.sysname)
// FIXME: .field("nodename", &self.nodename)
// FIXME: .field("release", &self.release)
// FIXME: .field("version", &self.version)
// FIXME: .field("machine", &self.machine)
// FIXME: .field("domainname", &self.domainname)
// FIXME(linux): .field("sysname", &self.sysname)
// FIXME(linux): .field("nodename", &self.nodename)
// FIXME(linux): .field("release", &self.release)
// FIXME(linux): .field("version", &self.version)
// FIXME(linux): .field("machine", &self.machine)
// FIXME(linux): .field("domainname", &self.domainname)
.finish()
}
}
Expand Down
16 changes: 8 additions & 8 deletions src/unix/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ missing! {
#[cfg_attr(feature = "extra_traits", derive(Debug))]
pub enum FILE {}
#[cfg_attr(feature = "extra_traits", derive(Debug))]
pub enum fpos_t {} // FIXME: fill this out with a struct
pub enum fpos_t {} // FIXME(unix): fill this out with a struct
}

extern "C" {
Expand Down Expand Up @@ -1325,11 +1325,11 @@ extern "C" {

#[cfg_attr(target_os = "netbsd", link_name = "__gmtime_r50")]
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
// FIXME: for `time_t`
// FIXME(time): for `time_t`
pub fn gmtime_r(time_p: *const time_t, result: *mut tm) -> *mut tm;
#[cfg_attr(target_os = "netbsd", link_name = "__localtime_r50")]
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
// FIXME: for `time_t`
// FIXME(time): for `time_t`
pub fn localtime_r(time_p: *const time_t, result: *mut tm) -> *mut tm;
#[cfg_attr(
all(target_os = "macos", target_arch = "x86"),
Expand All @@ -1345,19 +1345,19 @@ extern "C" {
pub fn time(time: *mut time_t) -> time_t;
#[cfg_attr(target_os = "netbsd", link_name = "__gmtime50")]
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
// FIXME: for `time_t`
// FIXME(time): for `time_t`
pub fn gmtime(time_p: *const time_t) -> *mut tm;
#[cfg_attr(target_os = "netbsd", link_name = "__locatime50")]
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
// FIXME: for `time_t`
// FIXME(time): for `time_t`
pub fn localtime(time_p: *const time_t) -> *mut tm;
#[cfg_attr(target_os = "netbsd", link_name = "__difftime50")]
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
// FIXME: for `time_t`
// FIXME(time): for `time_t`
pub fn difftime(time1: time_t, time0: time_t) -> c_double;
#[cfg_attr(target_os = "netbsd", link_name = "__timegm50")]
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
// FIXME: for `time_t`
// FIXME(time): for `time_t`
pub fn timegm(tm: *mut crate::tm) -> time_t;

#[cfg_attr(target_os = "netbsd", link_name = "__mknod50")]
Expand Down Expand Up @@ -1615,7 +1615,7 @@ cfg_if! {
all(target_os = "freebsd", any(freebsd11, freebsd10)),
link_name = "readdir_r@FBSD_1.0"
)]
#[allow(non_autolinks)] // FIXME: `<>` breaks line length limit.
#[allow(non_autolinks)] // FIXME(solaris): `<>` breaks line length limit.
/// The 64-bit libc on Solaris and illumos only has readdir_r. If a
/// 32-bit Solaris or illumos target is ever created, it should use
/// __posix_readdir_r. See libc(3LIB) on Solaris or illumos:
Expand Down
30 changes: 15 additions & 15 deletions src/unix/redox/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ pub const F_LOCK: c_int = 1;
pub const F_TLOCK: c_int = 2;
pub const F_TEST: c_int = 3;

// FIXME: relibc {
// FIXME(redox): relibc {
pub const RTLD_DEFAULT: *mut c_void = 0i64 as *mut c_void;
// }

Expand Down Expand Up @@ -504,7 +504,7 @@ pub const F_GETFD: c_int = 1;
pub const F_SETFD: c_int = 2;
pub const F_GETFL: c_int = 3;
pub const F_SETFL: c_int = 4;
// FIXME: relibc {
// FIXME(redox): relibc {
pub const F_DUPFD_CLOEXEC: c_int = crate::F_DUPFD;
// }
pub const FD_CLOEXEC: c_int = 0x0100_0000;
Expand All @@ -526,7 +526,7 @@ pub const O_DIRECTORY: c_int = 0x1000_0000;
pub const O_PATH: c_int = 0x2000_0000;
pub const O_SYMLINK: c_int = 0x4000_0000;
// Negative to allow it to be used as int
// FIXME: Fix negative values missing from includes
// FIXME(redox): Fix negative values missing from includes
pub const O_NOFOLLOW: c_int = -0x8000_0000;

// locale.h
Expand Down Expand Up @@ -567,7 +567,7 @@ pub const NI_NAMEREQD: c_int = 0x0008;
pub const NI_DGRAM: c_int = 0x0010;

// netinet/in.h
// FIXME: relibc {
// FIXME(redox): relibc {
pub const IP_TTL: c_int = 2;
pub const IPV6_UNICAST_HOPS: c_int = 16;
pub const IPV6_MULTICAST_IF: c_int = 17;
Expand All @@ -592,7 +592,7 @@ pub const IPPROTO_MAX: c_int = 255;

// netinet/tcp.h
pub const TCP_NODELAY: c_int = 1;
// FIXME: relibc {
// FIXME(redox): relibc {
pub const TCP_KEEPIDLE: c_int = 1;
// }

Expand Down Expand Up @@ -723,7 +723,7 @@ pub const EXIT_SUCCESS: c_int = 0;
pub const EXIT_FAILURE: c_int = 1;

// sys/ioctl.h
// FIXME: relibc {
// FIXME(redox): relibc {
pub const FIONREAD: c_ulong = 0x541B;
pub const FIONBIO: c_ulong = 0x5421;
pub const FIOCLEX: c_ulong = 0x5451;
Expand Down Expand Up @@ -1283,7 +1283,7 @@ cfg_if! {
.field("d_off", &self.d_off)
.field("d_reclen", &self.d_reclen)
.field("d_type", &self.d_type)
// FIXME: .field("d_name", &self.d_name)
// FIXME(redox): .field("d_name", &self.d_name)
.finish()
}
}
Expand Down Expand Up @@ -1315,7 +1315,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("sockaddr_un")
.field("sun_family", &self.sun_family)
// FIXME: .field("sun_path", &self.sun_path)
// FIXME(redox): .field("sun_path", &self.sun_path)
.finish()
}
}
Expand Down Expand Up @@ -1346,7 +1346,7 @@ cfg_if! {
f.debug_struct("sockaddr_storage")
.field("ss_family", &self.ss_family)
.field("__ss_align", &self.__ss_align)
// FIXME: .field("__ss_padding", &self.__ss_padding)
// FIXME(redox): .field("__ss_padding", &self.__ss_padding)
.finish()
}
}
Expand Down Expand Up @@ -1398,12 +1398,12 @@ cfg_if! {
impl fmt::Debug for utsname {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utsname")
// FIXME: .field("sysname", &self.sysname)
// FIXME: .field("nodename", &self.nodename)
// FIXME: .field("release", &self.release)
// FIXME: .field("version", &self.version)
// FIXME: .field("machine", &self.machine)
// FIXME: .field("domainname", &self.domainname)
// FIXME(redox): .field("sysname", &self.sysname)
// FIXME(redox): .field("nodename", &self.nodename)
// FIXME(redox): .field("release", &self.release)
// FIXME(redox): .field("version", &self.version)
// FIXME(redox): .field("machine", &self.machine)
// FIXME(redox): .field("domainname", &self.domainname)
.finish()
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/windows/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ impl Clone for FILE {
}
}
#[cfg_attr(feature = "extra_traits", derive(Debug))]
pub enum fpos_t {} // FIXME: fill this out with a struct
pub enum fpos_t {} // FIXME(struct): fill this out with a struct
impl Copy for fpos_t {}
impl Clone for fpos_t {
fn clone(&self) -> fpos_t {
Expand Down

0 comments on commit 2c456ae

Please sign in to comment.