Skip to content

Commit 6fce3f9

Browse files
committed
Revert "Move AtomicWaker from futures-core to futures-task"
This reverts commit dd664a3.
1 parent 3b39ea6 commit 6fce3f9

File tree

9 files changed

+19
-15
lines changed

9 files changed

+19
-15
lines changed

futures-channel/Cargo.toml

+2-3
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,11 @@ sink = ["futures-sink-preview"]
2323
# Unstable features
2424
# These features are outside of the normal semver guarantees and require the
2525
# `unstable` feature as an explicit opt-in to unstable API.
26-
unstable = ["futures-core-preview/unstable", "futures-task-preview/unstable"]
27-
cfg-target-has-atomic = ["futures-core-preview/cfg-target-has-atomic", "futures-task-preview/cfg-target-has-atomic"]
26+
unstable = ["futures-core-preview/unstable"]
27+
cfg-target-has-atomic = ["futures-core-preview/cfg-target-has-atomic"]
2828

2929
[dependencies]
3030
futures-core-preview = { path = "../futures-core", version = "=0.3.0-alpha.19", default-features = false }
31-
futures-task-preview = { path = "../futures-task", version = "=0.3.0-alpha.19", default-features = false }
3231
futures-sink-preview = { path = "../futures-sink", version = "=0.3.0-alpha.19", default-features = false, optional = true }
3332

3433
[dev-dependencies]

futures-channel/src/mpsc/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080

8181
use futures_core::stream::{FusedStream, Stream};
8282
use futures_core::task::{Context, Poll, Waker};
83-
use futures_task::AtomicWaker;
83+
use futures_core::task::__internal::AtomicWaker;
8484
use std::fmt;
8585
use std::pin::Pin;
8686
use std::sync::{Arc, Mutex};
+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#[cfg_attr(feature = "cfg-target-has-atomic", cfg(target_has_atomic = "ptr"))]
2+
mod atomic_waker;
3+
#[cfg_attr(feature = "cfg-target-has-atomic", cfg(target_has_atomic = "ptr"))]
4+
pub use self::atomic_waker::AtomicWaker;

futures-core/src/task/mod.rs

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
//! Task notification.
2+
3+
#[macro_use]
4+
mod poll;
5+
6+
#[doc(hidden)]
7+
pub mod __internal;
8+
9+
pub use core::task::{Context, Poll, Waker, RawWaker, RawWakerVTable};

futures-core/src/task.rs renamed to futures-core/src/task/poll.rs

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
//! Task notification.
2-
3-
pub use core::task::{Context, Poll, Waker, RawWaker, RawWakerVTable};
4-
51
/// Extracts the successful type of a `Poll<T>`.
62
///
73
/// This macro bakes in propagation of `Pending` signals by returning early.

futures-task/src/lib.rs

-5
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ mod spawn;
3030
pub use crate::spawn::{Spawn, SpawnError, LocalSpawn};
3131

3232
cfg_target_has_atomic! {
33-
#[cfg_attr(feature = "cfg-target-has-atomic", cfg(target_has_atomic = "ptr"))]
34-
mod atomic_waker;
35-
#[cfg_attr(feature = "cfg-target-has-atomic", cfg(target_has_atomic = "ptr"))]
36-
pub use crate::atomic_waker::AtomicWaker;
37-
3833
#[cfg(feature = "alloc")]
3934
mod arc_wake;
4035
#[cfg(feature = "alloc")]

futures-util/src/stream/futures_unordered/mod.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
use futures_core::future::Future;
77
use futures_core::stream::{FusedStream, Stream};
88
use futures_core::task::{Context, Poll};
9-
use futures_task::{FutureObj, LocalFutureObj, AtomicWaker, Spawn, LocalSpawn, SpawnError};
9+
use futures_task::{FutureObj, LocalFutureObj, Spawn, LocalSpawn, SpawnError};
10+
use crate::task::AtomicWaker;
1011
use core::cell::UnsafeCell;
1112
use core::fmt::{self, Debug};
1213
use core::iter::FromIterator;

futures-util/src/task/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ cfg_target_has_atomic! {
1010
#[cfg(feature = "alloc")]
1111
pub use futures_task::{waker_ref, WakerRef};
1212

13-
pub use futures_task::AtomicWaker;
13+
pub use futures_core::task::__internal::AtomicWaker;
1414
}
1515

1616
mod spawn;

0 commit comments

Comments
 (0)