From 227f358ab0bcecc43ee445fe9b35c780cf606dd2 Mon Sep 17 00:00:00 2001 From: Jiahao XU <30436523+NobodyXu@users.noreply.github.com> Date: Fri, 23 Aug 2024 23:25:45 +1000 Subject: [PATCH] Fix msrv: Run msrv checks with minimal versions NobodyXu Contributor NobodyXu commented 3 hours ago Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by gix. Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv. This would have also help discover bugs in #424 --- .github/workflows/main.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 25b643fe..80ef35f3 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -84,6 +84,9 @@ jobs: steps: - uses: actions/checkout@v4 - name: Install Rust (rustup) - run: rustup update ${version} --no-self-update && rustup default ${version} + run: | + rustup toolchain install ${version} nightly --profile minimal --no-self-update + rustup default ${version} + cargo +nightly update -Zminimal-versions shell: bash - run: cargo build