-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Licensing issues #72
Comments
I've been reading LICENSE of ring since @briansmith mentioned. I am not sure how docs.rs is breaking license terms of ring. docs.rs is also hosting a copy of LICENSE. AFAIK ISC license is similar to MIT and simplified BSD licenses. |
I'm not sure either, but I still think this is a good idea overall. |
I see. For some reason I'd overlooked it. |
I think, at a minimum, it's a good idea to more prominently display or link to the license, ideally near where "Author" is displayed. I think there's a broader issue of whether MIT, Apache, ISC, and other licenses require the copyright notice and license in each .rs file to be copied into the HTML, especially when the copyright notices in the .rs files aren't all uniform (e.g. different copyright holders) and/or when they are different from what's in the LICENSE file. Note, in particular, the top line of the ring LICENSE file. |
Triage: This could be part of #740 as templates are passed license files so a |
in this comment @briansmith mentions that docs.rs isn't following licenses properly.
https://github.com/briansmith/ring/blob/master/LICENSE is
*ring*
's license.I would imagine that it'd be a good idea to turn off generation for any crate that has something like this in its
Cargo.toml
.The text was updated successfully, but these errors were encountered: