Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fragment (#foo) links for foreign type implementations #269

Closed
Alexendoo opened this issue Nov 30, 2018 · 2 comments
Closed

Incorrect fragment (#foo) links for foreign type implementations #269

Alexendoo opened this issue Nov 30, 2018 · 2 comments

Comments

@Alexendoo
Copy link
Member

Example: https://docs.rs/serde/1.0.80/serde/trait.Serialize.html#impl-Serialize

All the links under Implementations on Foreign Types in the sidebar link to impl Serialize for bool

@jyn514
Copy link
Member

jyn514 commented Jul 27, 2020

This is a bug in rustdoc and was likely fixed between 2018 and now. You'd have to run cargo doc locally to confirm.

The reason it's still broken on the website is because of #464.

@jyn514
Copy link
Member

jyn514 commented Jul 27, 2020

Ok yes, if you look at https://docs.rs/serde/1.0.114/serde/trait.Serialize.html#impl-Serialize-for-char it goes to the correct implementation for char.

@jyn514 jyn514 closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants