Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 for favicon on recent docs #1070

Closed
Nemo157 opened this issue Sep 30, 2020 · 2 comments · Fixed by #1109
Closed

404 for favicon on recent docs #1070

Nemo157 opened this issue Sep 30, 2020 · 2 comments · Fixed by #1109
Assignees
@jyn514
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@Nemo157
Copy link
Member

Nemo157 commented Sep 30, 2020

e.g. https://docs.rs/chrono/0.4.18/chrono/

Since nightly-2020-09-26 it appears that rustdoc is using a .svg favicon, which isn't being stored as part of the essential files.
@jyn514 jyn514 added A-builds Area: Building the documentation for a crate C-bug Category: This is a bug labels Sep 30, 2020
@jyn514 jyn514 self-assigned this Oct 22, 2020
@jyn514 jyn514 mentioned this issue Oct 22, 2020
Merged
@icp1994
Copy link

icp1994 commented Oct 25, 2020

Is the change not live yet? The chrono favicon still doesn't load for me.

@jyn514
Copy link
Member

jyn514 commented Oct 25, 2020

@icp1994 that's #464. I'll see if I can rebuild chrono manually sometime today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyn514 jyn514

Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add favicon to essential files jyn514/docs.rs
3 participants
@Nemo157 @icp1994 @jyn514