CI: switch from cache to artifacts for caching test binaries across jobs

Author: syphar

.github/workflows/ci.yml

@@ -35,11 +35,12 @@ jobs:
             -executable -type f \
             -exec cp {} ./test-binaries/ \;
 
-      - name: set up test binaries to cache
-        uses: actions/cache@v2
+      - uses: actions/upload-artifact@v2
+        name: set up test binaries to cache
         with:
-          path: "./test-binaries"
-          key: test-binaries-${{ github.sha }}
+          name: test-binaries-${{ github.sha }}
+          path: ./test-binaries/
+          retention-days: 1
 
   test:
     runs-on: ubuntu-latest
@@ -48,10 +49,10 @@ jobs:
       - uses: actions/checkout@master
 
       - name: get test binaries from cache
-        uses: actions/cache@v2
+        uses: actions/download-artifact@v2
         with:
-          path: "./test-binaries"
-          key: test-binaries-${{ github.sha }}
+          name: test-binaries-${{ github.sha }}
+          path: ./test-binaries/
 
       - name: Launch postgres and min.io
         run: |
@@ -69,6 +70,7 @@ jobs:
         run: |
           for f in ./test-binaries/*; do
             echo "running $f"
+            chmod +x $f  # GH action artifacts don't handle permissions
             $f || exit 1
           done
 
@@ -83,10 +85,10 @@ jobs:
       - uses: actions/checkout@master
 
       - name: get test binaries from cache
-        uses: actions/cache@v2
+        uses: actions/download-artifact@v2
         with:
-          path: "./test-binaries"
-          key: test-binaries-${{ github.sha }}
+          name: test-binaries-${{ github.sha }}
+          path: ./test-binaries/
 
       - name: Launch postgres and min.io
         run: |
@@ -106,6 +108,7 @@ jobs:
         run: |
           for f in ./test-binaries/*; do
             echo "running $f"
+            chmod +x $f  # GH action artifacts don't handle permissions
             $f --ignored || exit 1
           done